1061894 - Intermittent 346258-1.html,394810-1.html,400349-1.html,616930-1.html,639737-1.html | assertion count 1 is more than expected

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47244413&tree=Mozilla-Central

Android 4.0 Panda mozilla-central debug test crashtest on 2014-09-02 12:15:04 PDT for push c24ec895b156
slave: panda-0151

12:34:13     INFO -  REFTEST TEST-START | http://10.26.128.22:30151/tests/js/xpconnect/crashtests/400349-1.html
12:34:13     INFO -  REFTEST TEST-LOAD | http://10.26.128.22:30151/tests/js/xpconnect/crashtests/400349-1.html | 900 / 2709 (33%)
12:34:13     INFO -  REFTEST TEST-PASS | http://10.26.128.22:30151/tests/js/xpconnect/crashtests/400349-1.html | (LOAD ONLY)
12:34:13     INFO -  REFTEST INFO | Loading a blank page
12:34:13     INFO -  REFTEST TEST-UNEXPECTED-FAIL | http://10.26.128.22:30151/tests/js/xpconnect/crashtests/400349-1.html | assertion count 1 is more than expected 0 assertions
12:34:13     INFO -  REFTEST TEST-END | http://10.26.128.22:30151/tests/js/xpconnect/crashtests/400349-1.html

From the logcat:
09-02 12:33:55.421 I/Gecko   ( 2124): [2124] ###!!! ASSERTION: Observers still registered?: '!mObserverList.mObserver && !mObserverList.mNext', file /builds/slave/m-cen-and-d-000000000000000000/build/content/base/src/nsImageLoadingContent.cpp, line 117

Comment 1

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=47267706&tree=Mozilla-Inbound
Android 4.0 Panda mozilla-inbound debug test crashtest on 2014-09-02 17:00:09
revision: 89f165978438
slave: panda-0259

REFTEST TEST-UNEXPECTED-FAIL | http://10.26.130.17:30259/tests/js/xpconnect/crashtests/400349-1.html | assertion count 1 is more than expected 0 assertions

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47309885&tree=Mozilla-Inbound#error7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47286252&tree=Mozilla-Inbound

Seth, these started happening pretty frequently in the last day or so. Any ideas?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47323766&tree=B2g-Inbound

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47325140&tree=Mozilla-Inbound

Quickly becoming a top manual-star orange.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Going back through inbound's history, it appears to have started shortly after bug 1008942 landed.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47325140&tree=Mozilla-Inbound

Comment 9

[Seth Fowler [:seth] [:s2h]]

Based on the code in that bug, it seems to be a very likely candidate indeed.

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I think image/test/crashtests/ownerdiscard.html is responsible. In fact I think bug 784591 is what introduced the bug into that test, I guess bug 1008942 just exposed it.

The patch for bug 784591 was wrong. If we move on because the image never gets decoded (and hence never discarded) we also need to cleanup by removing the observer the same way as if we do get decoded and discarded.

try run
https://tbpl.mozilla.org/?tree=Try&rev=2e9e937fdb12

Comment 12

[Timothy Nikkel (:tnikkel)]

Try run indicates the patch does indeed fix the problem.

Comment 14

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47368987&tree=Mozilla-Inbound

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47401217&tree=Mozilla-Inbound

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47415056&tree=Mozilla-Inbound

Seth, this is currently causing great pain on TBPL. Can you please find time for a quick review? :)

Comment 17

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8483778 [details] [diff] [review]
patch

Review of attachment 8483778 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 18

[Seth Fowler [:seth] [:s2h]]

I went ahead and pushed this since the need seems to be serious:

https://hg.mozilla.org/integration/mozilla-inbound/rev/65dead1492ba

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65dead1492ba

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 21

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8483778 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1008942
[User impact if declined]: none to users, but test failures that require manual staring by sheriffs
[Describe test coverage new/current, TBPL]: the patch fixes a test
[Risks and why]: fixing a text, no risk to users, been on mozilla-central for a few days with no problems
[String/UUID change made/needed]: none

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=47619328&tree=Mozilla-Aurora

Comment 23

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8483778 [details] [diff] [review]
patch

Aurora+

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10ce60dfd223