1063352 - the contact update/import button is in a weird place

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Dietrich Ayala (:dietrich)]

Attachment: screenshot

Flame, master, Sept 4.

Once you're at the screen where you can select contacts to import (or update), the import button itself is in a very odd place and doesn't look like a button.

It's up on the left, between the [x] button and the title. It's in inconsistently placed, and unbuttonlike - the combination of which makes this a bug.

On the page before it, the "done" button is in the expected location - top right on title bar.

Screenshot attached.

Comment 1

[Dietrich Ayala (:dietrich)]

Requesting UX feedback.

Comment 2

[Stephany Wilkes]

Dietrich, I can't see this on my device. Are you in the Browser, a Gmail app, or mobile Gmail, something else? Thanks!

Comment 3

[Dietrich Ayala (:dietrich)]

The Contacts app, per the component I filed this bug in.

STR:

1. Open Contacts
2. Click the gear icon
3. Click Import Contacts
4. Click Gmail
5. Log in to Google
6. Wait for it to get friends list

You are now on the screen which has this problem. Screenshot of the Import version coming soon.

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: Screenshot (import)

Comment 5

[Stephany Wilkes]

Ah ha - got it. Yeah that's... less than ideal. The layout during import is also a mess. Flagging Carrie.

Comment 6

[Stephany Wilkes]

And... describing the issue a bit more for triage posterity: I can see how this layout issue would prevent the user from being able to import contacts. After selecting some or all contacts to import, there appears to be no button for the user to click and no way to move forward to complete the import. The "Import" is tiny and not where one would expect to find a button, nor is it obvious that "Import" (which appears as non-clickable title text) is a button at all.

Comment 8

[Maria Angeles Oteo (:oteo)]

[Blocking Requested - why for this release]:

Nominating to 2.1 because there has not been any new design in 2.1 for changing this screen.

Leaving ni to Carrie and Fang to confirm it

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Wilson, i think this is caused by the new header component work. Do you still think that is a old gecko? Or is a issue in gaia?

Comment 10

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485782 [details] [review]
pull-request (master)

Working perfect!

Thanks Wilson!

Comment 12

[Jason Smith [:jsmith]]

I'm pretty sure this is a regression. Can we confirm this was working in 2.0?

Comment 14

[Joshua Mitchell (Inactive)]

regression confirmed - This bug does NOT repro in Flame 2.0

Actual Results - the import button is on the right side of the title bar (as expected)

Device: Flame 2.0
Build ID: 20140906031700
Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5
Gecko: 8e46e547f4ad
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 15

[Wilson Page [:wilsonpage]]

Comment on attachment 8485782 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/814fb3ba7da3f0bca0ef3f4d2433e2d1f38b091c

Comment 16

[Wilson Page [:wilsonpage]]

Attachment: pull-request (v2.1)

Comment 17

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: obvious UI defect.

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485892 [details] [review]
pull-request (v2.1)

LGTM in 2.1

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8485892 [details] [review]
pull-request (v2.1)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
New heades as a web component
[User impact] if declined:
Bad user experience, with buttons swapped
[Testing completed]:
Has been some days in master, looking good
[Risk to taking this patch] (and alternatives if risky):
Not pretty risky, is a change in dom placement
[String changes made]:

Comment 21

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.2
Gecko-eb14ebf
Gaia-7c5014a

Pending 2.1

Comment 22

[bhavana bajaj [:bajaj]]

Comment on attachment 8485892 [details] [review]
pull-request (v2.1)

very low risk visual change baked/test on master, approving to land on 2.1.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/300176d5b90445aea019905edafdd4ee83030d74

Comment 24

[Loli (:lolimartinezcr)]

Tested and working
2.1
Gecko-a50444f
Gaia-944e5b4

Comment 25

[John Thomas [:Johnt]]

This issue is verfied fixed for the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: The contact update/import button is in an appropriate place.