1063568 - Data technology icon overlaps with signal

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

Attachment: 2014-09-05-16-50-39.png

Reproduced on my Nexus S.

Comment 1

[Alberto Pastor [:albertopq]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23826

Comment 2

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: It breaks the statusbar for non multi-sim devices

Comment 3

[Eric Pang [:epang] UX]

Hi Alberto, just wanted to let you know that I'll test this when I get home today.  I only have the flame on me atm.

Comment 4

[mac]

Reproduced on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 2.2.0.0-prerelease master
Platform version: 35.0a1
Build Identifier: 20140828040204 
Git commit info: 2014-09-08 21:55:06 4acd3e69

Comment 5

[Eric Pang [:epang] UX]

Hi Alberto, I've added a spec to box:
https://mozilla.box.com/s/5idustp1aqb9locwyqaz

The main change is that the data is not left aligned with the signal icon.
Also I've reduced the font size.

let me know if you have any questions!

Comment 6

[Alberto Pastor [:albertopq]]

It seems I don't have access to that link :(

Comment 7

[yem_salat]

I think the proposed icon is too small, especially minding the screen quality of the devices that FxOS is aimed for.

Perhaps, would be better to put a 'full-size' icon next to the signal as it was before?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Spec 2.1] Single-Sim Connectivity

Albert, here is the spec.

Eric, when you update for new specs, will you attach them to the bug instead of posting links to dropbox? We should be making these specs public.

Comment 9

[Eric Pang [:epang] UX]

Attachment: [Spec 2.1] Single-Sim Connectivity

Hey Alberto, I've updated the spec to address the data connection being to small on lower resolutions devices - which we also noticed when testing yesterday.

Let me know if you have any questions.  Thanks!

Sorry about that Michael, I'll start uploading specs to the bugs.  The reason I've been using links is so that the latest spec is always seen.  But I can do both :).

Comment 10

[Alberto Pastor [:albertopq]]

Then, are we assuming that 1 sim means low resolution? What should be the behaviour with a multi-sim device, but only one SIM inserted?

Comment 11

[:gerard-majax]

I'm jumping on Alberto's answer: I thought we were trying to avoid loosing too much space. With the proposed design, we have much more space wasted when connected on data network when roaming.

Why don't we just have the same behavior than with multi-sim, and have a small letter indicating the network connectivity ?

Because we can have also Dual SIM with small screen and Single SIM with good screen.

Comment 12

[Alberto Pastor [:albertopq]]

Talked offline to Eric, and the visual team is going to try to find a solution that works well in high/low resolution and still don't consume that many space.

Will retake the bug after the specs are published here.

Comment 13

[Eric Pang [:epang] UX]

Attachment: [Visual Spec] Dual Sim Data Connection.jpg

Comment 14

[Eric Pang [:epang] UX]

Attachment: [Visual Spec] Single Sim Data Connection

Comment 15

[Alberto Pastor [:albertopq]]

Comment on attachment 8486049 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23826

Hey Eric, could you please ui-review? Thanks!

Comment 16

[Eric Pang [:epang] UX]

Attachment: 2014-09-12-01-28-21.jpg

Hey Alberto,

Looks like we need a few fixes

Dual Sim:

- Reduce weight of data - maybe 1 or two weights down (let’s try 2 first)
- Sim number need to be enlarged to match Data (same weight that we use above) and aligned to the bass of the signal icon

Single Sim:

- Reduce weight (which will be down above)
- Data needs to be raised by 1 px since it’s currently touching the signal icon
(I'm guessing if we do this for single sim that it will change for dual sim too?  I'm hoping this looks ok on the flame)

Comment 17

[Alberto Pastor [:albertopq]]

Hi Eric,

Just updated the patch with:

- font-weight reduced to 300 for both slot number and data type
- Increased font-size of slot number to 10px
- Data type raised 1px up (tested on a Keon and a Flame, and seems to be ok with the notifications bar)

Hope I'm not missing something, but let's iterate over it on Monday.

Comment 18

[Eric Pang [:epang] UX]

Comment on attachment 8486049 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23826

Looks good, thanks for troubleshooting an updating this! R+

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8486049 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23826

CSS-only change, ui-reviewed. LGTM.

Comment 20

[Michael Henretty [:mikehenrty][:mhenretty]]

Landing, because I want these changes on my dogfood phone.

master: https://github.com/mozilla-b2g/gaia/commit/c21106017e7def8a436ec807a9fda746de5504ca

Comment 21

[Michael Henretty [:mikehenrty][:mhenretty]]

Alberto, does this change depend on the roaming changes in bug 1056969? I think they do because the new data signal icon is in place of where the roaming icon used to be. If so, we will need to have those uplifted first. The sooner we do that the better, since those are polish bugs and this is blocking.

Comment 22

[Alberto Pastor [:albertopq]]

Are you saying that you are experiencing this bug in 2.1? I thought none of the new data connections visual specs actually landed in 2.1. I'll try it tomorrow.

Comment 23

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alberto Pastor [:albertopq] from comment #22)
> Are you saying that you are experiencing this bug in 2.1? I thought none of
> the new data connections visual specs actually landed in 2.1. I'll try it
> tomorrow.

Hrmm, it looks like you requested this bug to block 2.1? If we are not experiencing this on 2.1, we can probably just remove the blocking flag.

Comment 24

[Alberto Pastor [:albertopq]]

Sorry about that. That wasn't meant to be asked for blocking.
I'll double check tomorrow if it works properly in 2.1 before removing the flag, though.

Thanks!

Comment 25

[Alberto Pastor [:albertopq]]

v2.1 is not affected by this. Unflagging.

At the other hand, not sure if Bug 1056969 is in fact blocking making space to the rocketbar, so may be we need to uplift it (and all the dependents, including this one).

What do you think?

Comment 26

[Michael Henretty [:mikehenrty][:mhenretty]]

I think we should to be honest. Bug 1056969 solves a lot of spacial issues for the statusbar. Also, we still have a lot of polish work to do for 2.1 in the statusbar, and having master and 2.1 diverge can really complicate that issue.

Comment 27

[Alberto Pastor [:albertopq]]

+1

How can we start that process?

Comment 28

[Michael Henretty [:mikehenrty][:mhenretty]]

I guess just start with request uplift on bug 1056969. Be as detailed as you can about why it's important to have it (ie. spacing issues and keeping complexity of fixing further statusbar bugs across branches). And make sure to mention this bug and bug 1066557 there in that request, so they know what this entails. We'll go from there.

Comment 29

[Alberto Pastor [:albertopq]]

Comment on attachment 8486049 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23826

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1056969
[User impact] if declined: Data icon overlaps with the signal when only 1 sim
[Testing completed]: Manual tests
[Risk to taking this patch] (and alternatives if risky): Low risk, only CSS
[String changes made]: -

Comment 30

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Regression from 1056969, which has been uplifted

Comment 31

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0ecd0d7373873c6a46e7ffc50ef0269dc3b4e06d

Comment 33

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Buri 2.1 and 2.2.

Result: The data icon does not overlap with the signal icon on a single-SIM device.

Device: Buri 2.1
BuildID: 20141118001204
Gaia: 1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko: 95fbd7635152
Version: 34.0 (2.1) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Buri 2.2
BuildID: 20141118040205
Gaia: 4aee256937afe9db2520752650685ba61ce6097d
Gecko: 7913c9392c5f
Version: 36.0a1 (2.2) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0