1068811 - X11 cut-and-paste broken with e10s

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Ralph Giles (:rillian)]

Since enabling e10s in nightly, Middle-click cut and paste doesn't work.

Windows-style ctrl-c, ctrl-v cut and paste does work. If something's in the paste buffer from a ctrl-c, middle click will paste it. However, making a new selection does not change the contents of the middle-click paste buffer.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

This was bothering me enough that I had to fix it. This is the most straightforward way of solving this bug (as far as I know). I thought about simply adding two more sync functions that we always call, but the return values of these functions will never change, so I decided to avoid that.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c8220e02f0be

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1.1

Unified builds struck me. I wasn't 'using' enough from mozilla::dom in the previous patch for the nsClipboardProxy.cpp to compile by itself.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c4291086b00

Comment 8

[Nigel Babu [:nigelb]]

I *think* this broke https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3154819&repo=mozilla-inbound on B2g linux desktop. Especially since the failure is in Clipboard. Can you take a look?

Comment 9

[(Away)]

Backed out at nigelb's request: https://hg.mozilla.org/integration/mozilla-inbound/rev/530811c1e3ea

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: followup fix for b2g

I'd assumed that our clipboard proxy was the only nsIClipboard implementation in child processes. That was not true, thanks to b2g.  With this patch, we can be sure to not crash if we're talking to the wrong child-process clipboard implementation.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=129039044475

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Combined patch for checkin

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58a2d8002e00

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/58a2d8002e00