Closed Bug 1070614 Opened 7 years ago Closed 7 years ago

Fix some TypeErrors and SyntaxErrors seen in JS strict mode when running mozmill tests

Categories

(Thunderbird :: General, defect)

defect
Not set
trivial

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(3 files, 1 obsolete file)

JavaScript strict warning: resource:///modules/msgDBCacheManager.js, line 131: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function

JavaScript strict warning: file:///tbird-bin/dist/bin/components/imContacts.js, line 101: SyntaxError: in strict mode code, functions may be declared only at top level or imm
ediately within another function

JavaScript strict warning: file:///tbird-bin/dist/bin/components/nsAbAutoCompleteSearch.js, line 364: SyntaxError: in strict mode code, functions may be declared only at top
level or immediately within another function

JavaScript strict warning: resource://mozmill/modules/frame.js -> file:///mail/test/mozmill/tabmail/test-tabmail-dragndrop.js, line 328: TypeError: "recentlyClosedTabs" is read-only
Attached patch 1070614-imSplinter Review
Attachment #8492637 - Flags: review?(florian)
Attached patch 1070614-tbSplinter Review
Attachment #8492638 - Flags: review?(mkmelin+mozilla)
Attached patch 1070614-mn (obsolete) — Splinter Review
Attachment #8492639 - Flags: review?(neil)
Comment on attachment 8492637 [details] [diff] [review]
1070614-im

Thanks!
Attachment #8492637 - Flags: review?(florian) → review+
Attached patch 1070614-mn v2Splinter Review
Small nit from Neil.
Attachment #8492639 - Attachment is obsolete: true
Attachment #8492639 - Flags: review?(neil)
Attachment #8492664 - Flags: review?(neil)
Attachment #8492664 - Flags: review?(neil) → review+
Attachment #8492638 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
Duplicate of this bug: 1072907
Duplicate of this bug: 1048521
Blocks: 826732
https://hg.mozilla.org/comm-central/rev/53b401928f08
https://hg.mozilla.org/comm-central/rev/b03be9fe6acd
https://hg.mozilla.org/comm-central/rev/acbcfef22bd3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.