1070614 - Fix some TypeErrors and SyntaxErrors seen in JS strict mode when running mozmill tests

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:aceman]

JavaScript strict warning: resource:///modules/msgDBCacheManager.js, line 131: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function

JavaScript strict warning: file:///tbird-bin/dist/bin/components/imContacts.js, line 101: SyntaxError: in strict mode code, functions may be declared only at top level or imm
ediately within another function

JavaScript strict warning: file:///tbird-bin/dist/bin/components/nsAbAutoCompleteSearch.js, line 364: SyntaxError: in strict mode code, functions may be declared only at top
level or immediately within another function

JavaScript strict warning: resource://mozmill/modules/frame.js -> file:///mail/test/mozmill/tabmail/test-tabmail-dragndrop.js, line 328: TypeError: "recentlyClosedTabs" is read-only

Comment 1

[:aceman]

Attachment: 1070614-im

Comment 2

[:aceman]

Attachment: 1070614-tb

Comment 3

[:aceman]

Attachment: 1070614-mn

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8492637 [details] [diff] [review]
1070614-im

Thanks!

Comment 5

[:aceman]

Attachment: 1070614-mn v2

Small nit from Neil.

Comment 6

[:aceman]

Thanks.

Comment 9

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/53b401928f08
https://hg.mozilla.org/comm-central/rev/b03be9fe6acd
https://hg.mozilla.org/comm-central/rev/acbcfef22bd3