Closed Bug 1073339 Opened 5 years ago Closed 5 years ago

Investigate autocomplete test unreliability on Linux/e10s

Categories

(Firefox :: Address Bar, defect)

All
Linux
defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
e10s + ---

People

(Reporter: Unfocused, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 5 obsolete files)

Bug 1072320 ended up being quite a rabbithole of inproductivity. We have a set of tests that aren't reliable on Linux (and so have been disabled there):

browser_action_keyword.js
browser_action_searchengine.js
browser_action_searchengine_alias.js

AFAICT, this is because when the test tries to interact with the autocomplete result, nothing happens. My assumption is that this is due to focus issues around popups on Linux, which we've had troubles with in the past.
Also browser_search_favicon.js.  I can see the same problem intermittently with e10s on Windows, and see no reason to believe they are different - so I'm opening a new bug to also disable these tests with e10s keeping this bug number as the reason.

As to the reason: I'm seeing that the failure in e10s is caused due to detachController in autocomplete.xml being called during the test, causing the search to stop before we've got the results we expect.  detachController is called via:

_adjustFocusAfterTabSwitch@chrome://browser/content/tabbrowser.xml:1251:9
_finalizeTabSwitch@chrome://browser/content/tabbrowser.xml:3273:11
set_selectedIndex/<@chrome://browser/content/tabbrowser.xml:5252:15
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7

which is tabbrowser focusing the new tab asynchronously.
Summary: Investigate autocomplete test unreliability on Linux → Investigate autocomplete test unreliability on Linux/e10s
Depends on: 1075450
This is based off of the patches from bug 1075450.
Attachment #8527295 - Flags: review?(mak77)
Windows -> Unix line endings.
Attachment #8527296 - Flags: review?(mak77)
Comment on attachment 8527295 [details] [diff] [review]
0001-Bug-1073339-Enable-autocomplete-tests-for-Linux-and-.patch

Review of attachment 8527295 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for looking into this :) It's been driving me batty.

Will also need to deal with browser_autocomplete_autoselect.js, added in bug 1067903.

::: browser/base/content/test/general/browser_action_searchengine.js
@@ +8,5 @@
>  
>    Services.search.addEngineWithDetails("MozSearch", "", "", "", "GET",
>                                         "http://example.com/?q={searchTerms}");
>    let engine = Services.search.getEngineByName("MozSearch");
> +  let gOriginalEngine = Services.search.currentEngine;

Nit: Rename, so we don't accidentally assume it's a global?
Attachment #8527295 - Flags: review?(mak77) → review-
Attachment #8527296 - Flags: review?(mak77) → review+
Oh, would be good to also update browser_autocomplete_a11y_label.js too, for consistency.
Blocks: 1099046
Assignee: nobody → ttaubert
Attachment #8527295 - Attachment is obsolete: true
Attachment #8527296 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8530242 - Flags: review?(bmcbride)
Attachment #8530242 - Attachment is obsolete: true
Attachment #8530242 - Flags: review?(bmcbride)
Attachment #8530243 - Flags: review?(bmcbride)
Try push with unifiedcomplete=false:

https://tbpl.mozilla.org/?tree=Try&rev=3ee73b9c370d

Try push with unifiedcomplete=true:

https://tbpl.mozilla.org/?tree=Try&rev=2d7106bda22e
Iteration: --- → 37.1
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
Doesn't look great with e10s and unifiedcomplete enabled. If only I could run e10s tests locally...
you can by passing --e10s to mach mochitest-browser?
Currently broken due to bug 1103159 unfortunately.
Attachment #8530243 - Flags: review?(bmcbride) → review+
Attachment #8530242 - Attachment is obsolete: false
Comment on attachment 8530242 [details] [diff] [review]
0001-Bug-1073339-Enable-autocomplete-tests-for-Linux-and-.patch, v2

Review of attachment 8530242 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see any obvious reason why this is failing on Try :\
Attachment #8530242 - Flags: review-
Iteration: 37.1 → 37.2
Updated due to test changes.
Attachment #8530243 - Attachment is obsolete: true
Attachment #8535550 - Flags: review+
Comment on attachment 8535551 [details] [diff] [review]
0001-Bug-1073339-Enable-autocomplete-tests-for-Linux-and-.patch, v3

Review of attachment 8535551 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser.ini
@@ -110,5 @@
>  [browser_aboutHome.js]
>  skip-if = e10s # Bug 1093153 - no about:home support yet
>  [browser_aboutSyncProgress.js]
>  [browser_action_keyword.js]
> -skip-if = os == "linux" || e10s # Bug 1073339 - Investigate autocomplete test unreliability on Linux/e10s

Look like browser_action_keyword.js should get updated too.
Attachment #8535551 - Flags: review?(bmcbride) → review-
Blocks: 1104755
Attachment #8536635 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/d68830b2ce47
https://hg.mozilla.org/mozilla-central/rev/704ca3c0bb46
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Depends on: 1566776
You need to log in before you can comment on or make changes to this bug.