1074002 - Modify file structure of Thunderbird.app to allow for OSX v2 signing

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Port of bug 1047584 for Thunderbird

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

I won't have time to drive this into the tree.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8496625 [details] [diff] [review]
patch

forgot to refresh

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

one more try... forgot some additional binaries

Comment 6

[Javi Rueda :javirid]

I had been unable to execute Thunderbird from my own build tree some time ago. It showed just the "Couldn't load XPCOM" message on the OS X Terminal. Trying to get any solution to the problem -once clobbering and remove+cloning the repo- I found bug 1074006 and this one. qpush'ing into my patch queue fixed it -I felt so happy!!-

Now: is there any reason why those bugs aren't landing into c-c?

*Thank you*, Robert for this fix.

Comment 7

[Josiah Bruner [:jsbruner]]

Because I can't test this thoroughly yet until tomorrow, and possibly a day later. Unfortunately to test this properly I need a first-ever-ran-on-the-os situation, which means I need to get some stuff in order for testing. Hopefully though those two bugs should be landed by Tuesday at the latest.

Comment 9

[Josiah Bruner [:jsbruner]]

Patch landed: https://hg.mozilla.org/comm-central/rev/e8b40904de39

I'm not sure if this bug is resolved yet, I'm going to keep it open for a week or so to make sure, I still want to test on more OS X platforms and do more first-launches, but this is necessary to get OS X to build.

Comment 10

[Josiah Bruner [:jsbruner]]

Also, that revision landed with my name, but Robert did most of the work. However, since I'm sure Robert is busy, any followups, additional patches, or information will be provided by me.

Thanks again Robert!

Comment 11

[Robert Strong (they/them - no direct email)]

Heads up that Mac V2 signing also landed on Aurora today. We are still discussing whether it will be uplifted to esr31 since from what I know we won't be able to whitelist for the entire esr31 lifecycle but we are leaning towards not uplifting at this time.

Comment 12

[Josiah Bruner [:jsbruner]]

Comment on attachment 8496630 [details] [diff] [review]
patch

This is already on Aurora, so it only needs to be uplifted to beta.

[Approval Request Comment]
Regression caused by (bug #): V2 Codesigning 
User impact if declined: 
Testing completed (on c-c, etc.): On c-c and c-a
Risk to taking this patch (and alternatives if risky):

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/bf0db45180a6