Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: phlsa, Assigned: phlsa)

Tracking

33 Branch
x86
All
Points:
8
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ux])

Attachments

(3 attachments, 1 obsolete attachment)

The engineering work on Loop has been going on without any design review so far. It's time to do a review of what is currently in Nightly.
Flags: firefox-backlog+
Flags: qe-verify-
Whiteboard: [ux]
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Iteration: --- → 35.2
Points: --- → 8
Posted image Loop Review V1 (obsolete) —
Here's what I could catch.
Attachment #8497452 - Flags: review?(dhenein)
(In reply to Philipp Sackl [:phlsa] from comment #1)
> Here's what I could catch.

Hey Philipp, any chance you could look at the Contacts UI that just landed in fx-team? (It's not in mozilla-central yet.) There are probably adjustments to do there as well.

For now the video call button does nothing, and audio/video call context menu items are not active, but the rest should work as expected.
Flags: needinfo?(philipp)
(In reply to :Paolo Amadini from comment #2)
> (In reply to Philipp Sackl [:phlsa] from comment #1)
> > Here's what I could catch.
> 
> Hey Philipp, any chance you could look at the Contacts UI that just landed
> in fx-team? (It's not in mozilla-central yet.) There are probably
> adjustments to do there as well.
> 
> For now the video call button does nothing, and audio/video call context
> menu items are not active, but the rest should work as expected.

Generally yes, but that should probably happen in a different bug.
Also, is there a place where I can download a build of fx-team, or do I have to build that myself?
Flags: needinfo?(philipp)
(In reply to Philipp Sackl [:phlsa] from comment #3)
> Also, is there a place where I can download a build of fx-team, or do I have
> to build that myself?

Generally, you can go to <https://tbpl.mozilla.org/?tree=Fx-Team>, select a green "B" letter on the right for the platform you're interested into, click the small "go to build directory" link in the lower left corner, and then select the right file from the list. Intuitive!
Iteration: 35.2 → 35.3
Depends on: 1075203
Hi,

Is the review done with Mac only?
Do you consider the following bugs appropriate to report as part of this review?
Fonts on windows : https://bugzilla.mozilla.org/show_bug.cgi?id=1065537
Blurry logo on windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1074284
Blurry client icons: https://bugzilla.mozilla.org/show_bug.cgi?id=1068593
Blurry camera icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1060590
Blurry accept icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1068594

Some more comments:
* The "Cancel and block" button is too small (similar to number 5 with "Voice conversation") - attached screenshot
* The feedback form displays a vertical scroll bar - attached screenshot
Vertical scroll bar on feedback form (Windows 8)
Posted image Cancel and block.png
Cancel and block button too small
(In reply to Romain Testard [:RT] from comment #5)
> Hi,
> 
> Is the review done with Mac only?
> Do you consider the following bugs appropriate to report as part of this
> review?
> Fonts on windows : https://bugzilla.mozilla.org/show_bug.cgi?id=1065537
> Blurry logo on windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1074284
> Blurry client icons: https://bugzilla.mozilla.org/show_bug.cgi?id=1068593
> Blurry camera icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1060590
> Blurry accept icon: https://bugzilla.mozilla.org/show_bug.cgi?id=1068594
> 
> Some more comments:
> * The "Cancel and block" button is too small (similar to number 5 with
> "Voice conversation") - attached screenshot
> * The feedback form displays a vertical scroll bar - attached screenshot

I did test on Windows (8) and Linux as well (see #9 in the review comp).
The bugs you've listed all look very valid to me. Some are already included in the comp as well. I will update it to also show the bug numbers and add the ones missing.
Posted image Updated review
Updated comp including the issues raised by Romain as well as some bug numbers.
Attachment #8497452 - Attachment is obsolete: true
Attachment #8497452 - Flags: review?(dhenein)
Got a verbal r+ from Darrin the other day, so I'm marking this as fixed.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.