1077148 - Define mozglue dependencies in moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Currently, we use awful rules in config.mk, based on MOZ_GLUE_LDFLAGS and MOZ_GLUE_PROGRAM_LDFLAGS to link against mozglue. And a set of directories opt out by emptying those variable. We already have code in mozbuild to make essentially everything depend on mozglue so that things build in the right order. That's horrible in many ways, but the main point is that it's all outside of moz.build scope which it shouldn't.

Also, when working on mfbt .cpp files or jemalloc (or other mozglue things, such as the linker) on Linux, it makes mach build binaries not pick up changes because of missing dependencies for executables.

Comment 1

[Mike Hommey [:glandium]]

Attachment: part 1 - Define mozcrt in moz.build

Note the recursivemake.py change is temporary and goes away in subsequent parts.

Comment 2

[Mike Hommey [:glandium]]

Attachment: part 2 - Remove hack to avoid sqlite being linked against mozglue on mac

This hack has actually not been actively used since sqlite, nss and nspr are
all folded together, because no shared library is actually linked in
db/sqlite3/src.

Comment 3

[Mike Hommey [:glandium]]

Attachment: part 3 - Do not link PrimitiveTest, SimpleTypeLib, TestAUSHelper, TestAUSReadStrings and screentopng against mozglue on Linux

There is no reason these should be linked to mozglue on Linux only. This
makes the intent clearer for the related changes in part 4.

Comment 4

[Mike Hommey [:glandium]]

Attachment: part 4 - Add and use new moz.build templates for Gecko programs and libraries

There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.

Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.

Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8512470 [details] [diff] [review]
part 4 - Add and use new moz.build templates for Gecko programs and libraries

Review of attachment 8512470 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice. I love how our complex linking situation keeps getting easier to understand.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2f1416473f
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b5bb9e867a
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a59d60cf8ad
https://hg.mozilla.org/integration/mozilla-inbound/rev/55d15b285436

Comment 7

[Mike Hommey [:glandium]]

And a fixup:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c24de5c098e

Comment 8

[Mike Hommey [:glandium]]

Another fixup:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7e5e992530

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c2f1416473f
https://hg.mozilla.org/mozilla-central/rev/a7b5bb9e867a
https://hg.mozilla.org/mozilla-central/rev/0a59d60cf8ad
https://hg.mozilla.org/mozilla-central/rev/55d15b285436
https://hg.mozilla.org/mozilla-central/rev/1c24de5c098e
https://hg.mozilla.org/mozilla-central/rev/cb7e5e992530