1080947 - UITour: tell the page when a Hello room view opens or closes

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

The Hello tour needs to know when a room view ("conversation") is opened or closed:

* After guiding the user to click "New Room", we want to then point to the room view and ask them to click Email/Copy Link.
* If the user closes the view instead of sharing a link, we want to adjust the tour (so it's not pointing at a non-existent view)
* At the end of a successful conversation, we'd like to know they're done.

Note that it's possible for a user to create multiple rooms (and close them!).

The backend of this should probably involve Hello using existing message passing mechanisms to tell chrome (UITour) that a view was opened/closed, and then UITour can notify any existing tour pages. API TBD -- probably want the page to explicitly opt-in to receiving notifications/callbacks, but we could also just create and fire DOM events at the tour page.

Some possible overlap with bug 1080944 -- the open notification could include the size/position of the room view.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1080947/MattN

Comment 2

[Matthew N. [:MattN]]

/r/1155 - Bug 1080947 - UITour: tell the page when a Hello chat window opens or closes. r=Standard8

Pull down this commit:

hg pull review -r 396d3507485be897160c9c79163317d185e13a86

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://reviewboard.mozilla.org/r/1153/#review669

r+ on the parts I know anything about (ie, not including Loop)

::: browser/components/loop/MozLoopService.jsm
(Diff revision 1)
> +          UITour.notify("LoopChatWindowClosed");

My preference would be to namespace these event names, to help add organisation/structure.

So something like "Loop:ChatWindowClosed"

Comment 4

[Matthew N. [:MattN]]

/r/1155 - Bug 1080947 - UITour: tell the page when a Hello chat window opens or closes. r=Standard8,Unfocused

Pull down this commit:

hg pull review -r bf99280c56242476b2aab3ac73acc98951c2091f

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://reviewboard.mozilla.org/r/1153/#review681

::: browser/components/loop/MozLoopService.jsm
(Diff revision 2)
> +        chatbox.contentWindow.addEventListener("unload", function onUnloadChat(evt) {
> +          UITour.notify("Loop:ChatWindowClosed");
> +        });
> +
>          let window = chatbox.contentWindow;

Move 'let window = ...' to above the addEventListener line.

Comment 6

[Mark Banner (:standard8)]

https://reviewboard.mozilla.org/r/1153/#review683

Ship It!

Comment 7

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/fa30abee420e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fa30abee420e

Comment 9

[Justin Dolske [:Dolske]]

Comment on attachment 8532332 [details]
MozReview Request: bz://1080947/MattN

[Triage Comment]

Needed for Fx35 Hello tour, no unusual risk.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cfbca1e76c9b

Comment 11

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/45b05c3d7478

Comment 13

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1080947 - UITour: tell the page when a Hello chat window opens or closes. r=Standard8,Unfocused