108567 - download dialog "stretching" icon

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[(not reading, please use [e-mail] instead)]

download dialog "stretching" icon

screen shot coming.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Scott MacGregor]

nominating.

Comment 3

[(not reading, please use [e-mail] instead)]

over to law.

blake tells me that "users of <image> just have to make sure it's wrapped in a
box that doesn't stretch, now"

this falls out of a recent landing of hyatt's, according to blake.

Comment 4

[Grey Hodge (jX)]

Yeah, probably related to the ICO/Etc. renderer checkin deal. I must admit, it's
kinda growing on me this way, ;)

Comment 5

[hirata masakazu]

This seems to cause the buttons at the bottom of the dialog to get placed out of 
bounds once you use "choose" application to open the downloaded file.
Mac trunk 2001110

Comment 6

[R.K.Aa.]

*** Bug 109626 has been marked as a duplicate of this bug. ***

Comment 7

[sairuh (rarely reading bugmail)]

*** Bug 108875 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

*** Bug 110728 has been marked as a duplicate of this bug. ***

Comment 9

[R.K.Aa.]

*** Bug 111329 has been marked as a duplicate of this bug. ***

Comment 10

[R.K.Aa.]

see also bug 111372

Comment 11

[Chris Brien]

Attachment: Patch to nsHelperAppDlg.xul

<Seth Spitzer>
blake tells me that "users of <image> just have to make sure it's wrapped in a
box that doesn't stretch, now"
</Seth Spitzer>

Ok, this patch creates the needed non-stretchy box

Comment 12

[Chris Brien]

Attachment: Patch to nsHelperAppDlg.xul

**** **** **** **** ****. Always test your patches before submitting. ALWAYS
test your patches before submitting.

Updated patch - it works now!

Comment 13

[Håkan Waara]

Comment on attachment 58899 [details] [diff] [review]
Patch to nsHelperAppDlg.xul

I hate this bug.

r=hwaara

Comment 14

[Chris Brien]

Thanks Håkan. Whats the chances of this getting into the tree any time soon?
What do I have to do? Who do I have to email/beg/kill?

You might also want to look at bugs 110456 & 111372 - very similar bugs, with
very similar patches. But I can't add the patch keyword, so they're unlikely to
be found .

Comment 15

[Bill Law]

Attachment: patch for both the helper app dialog and the helper app pref panel

This patch fixes both places.  Reviews, please?

Thanks for the help, BTW.

Comment 16

[Blake Ross]

The default alignment is stretch. Why does this work?

Comment 17

[Bill Law]

Got me.  I don't know why it broke, either.  I'm just collecting the patches and
checking them in.  Anybody?

Comment 18

[Bill Law]

Comment on attachment 59792 [details] [diff] [review]
patch for both the helper app dialog and the helper app pref panel

r=hwaara (for the one file)
r=bzbarsky (for the other)

Comment 19

[Bill Law]

Comment on attachment 59792 [details] [diff] [review]
patch for both the helper app dialog and the helper app pref panel

r=hwaara (for the one file)
r=bzbarsky (for the other, from bug 111372)

Comment 20

[Blake Ross]

It broke because hyatt fixed it so xul <image/>s stretch.  Thinking about it 
further, I think the fixes make sense.  After all, the vbox does stretch, but 
it doesn't contain anything else forcing it to size more than the image size. 
As far as I can see.  So sr=me.

Comment 21

[Bill Law]

fixed

Comment 22

[sairuh (rarely reading bugmail)]

vrfy fixed on winnt, mac 10.1.1 and mac 9.1 using 2001.12.05.0x-comm bits.