1087813 - [Flatfish][Settings] Unable to entry in menus

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Raniere Silva]

Steps to Reproduce:

1. Open Settings app
2. Select one element from the list (e.g. Wi-fi)
	 
Actual Results:

Nothing happens.
	 
Expected Results:

The settings for the element select be showed.

Gaia Commit Used:

commit 3536e6038212f9c5dc08a763ed6555494f24e38b
Merge: 27a1d1b 2eb946b
Author: Fabrice Desré <[e-mail]>
Date:   Wed Oct 22 12:26:12 2014 -0700

    Merge pull request #25231 from clouserw/1083528
    
    Bug 1083528 - Ship engineering builds with correct dev/stage Marketplaces r=fabrice

Comment 2

[Merike Sell (:merike)]

Seeing this too with 1024 build. I though it might be a duplicate of bug 1078786 but that one seems memory related. I cannot open any settings page even after rebooting so it cannot be that.

Comment 3

[Carlo 'Carcarlo' Carmagnini]

I am experiencing this bug on both 20141024 and 20141025 build.
Nothing happens when you tap on the Settings menu, the right part of the screen remains completely blank.
I went to Settings just after having flashed the new build, no other apps have been opened.

Comment 5

[Gabriela [:gaby2300]]

I have the same issue in my Flame using base image 188 and the latest OTA updates.
It's not always reproducible though.

Comment 6

[Safwan Rahman (:safwan)]

I think its a regression which may be cause if any commit from 15-23 October. Anyone can find the first bad commit?

Comment 7

[YF (Yang)]

I suspect the cause due to bug 1007600 patch. Who can confirm this?


I notice that the run the 'Settings.rotate()' in Settings app via WebIDE solve this problem. The bug reason seems to the "window.addEventListener('screenlayoutchange', this.rotate);" has not take effect.

Comment 8

[YF (Yang)]

https://github.com/mozilla-b2g/gaia/blob/136b7c7baaa3baf3acdea4fa8ca49a96d8c79dc8/apps/settings/js/settings.js#L25 & L108.

Comment 10

[Safwan Rahman (:safwan)]

Hi Yang,
If you go through the history of Setting app,(1) you can see that Pull request #25296 is the just before patch landed in setting. I have tried to test with only the patch, but it also has the same problem. I have installed the setting app of the #25296 pull request's blob with App manager, but it seems the problem is also there!
So I think bug 1007600 is not responsible of the problem. Maybe, any commit submitted before that is responsible for it!

Comment 11

[Safwan Rahman (:safwan)]

oops, forgot to add the history lnk
1. https://github.com/mozilla-b2g/gaia/commits/master/apps/settings?page=2

Comment 12

[YF (Yang)]

(In reply to Safwan Rahman from comment #10)
> Hi Yang,
> If you go through the history of Setting app,(1) you can see that Pull
> request #25296 is the just before patch landed in setting. I have tried to
> test with only the patch, but it also has the same problem. I have installed
> the setting app of the #25296 pull request's blob with App manager, but it
> seems the problem is also there!
> So I think bug 1007600 is not responsible of the problem. Maybe, any commit
> submitted before that is responsible for it!

Ah, thank you for the test. I just suspect it because it is a larger changes looks, no evidence or verification because I don't have a suitable machine for build B2G yet.

Um, I did not found a clear suspicious changes in the previous commits for Settings app...

Comment 14

[YF (Yang)]

Attachment: patch v1

The patch seems to fixes the issue, although I did not found the first regression.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8520151 [details] [review]
patch v1

Thanks YF, can you help to add one more test case to make sure that in tablet, that function would really be called after in next tick ? Thanks !! :)

Comment 16

[YF (Yang)]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #15)
> Comment on attachment 8520151 [details] [review]
> patch v1
> 
> Thanks YF, can you help to add one more test case to make sure that in
> tablet, that function would really be called after in next tick ? Thanks !!
> :)

Unfortunately, I do not have any experience in writing test cases, and I have not a suitable environment, I once tried but was not successful.

Feel free to submit a better patch , I expect it to be repaired as soon as possible because it is a blocker.

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

ok, i will use your commit as base and add mine on top of it. In this way, you are still the author of this patch and would be shown on Github.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master (2.2)

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8520536 [details] [review]
patch on master (2.2)

r+ with green light.

Comment 20

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks YF, merged into Gaia/master (2.2): https://github.com/mozilla-b2g/gaia/commit/95181531ede38384b8e64515349c4a1215e7034a

Comment 21

[eva.chen.fx]

Verified fix on the 20141113 TCP build.

Enviromental Variables:
Device  : Flatfish 2.2 Master
B2G     : 2.2.0.0-prerelease
Gaia    : d13f29ef7b1656dbb555730dc161f89a1d25ce48
Gecko   : b3c105d5da5b2657d8ea0979646a9b4bb8a1e065
BuildID : 20141113011509
Version : 36.0a1

Comment 22

[Adrian Crespo]

Not fixed:
1) Select the Wi-Fi menu.
2) Search some access points.
3.1) Tap in any access point.
4.1) Nothing happens.

3.2) Tap in "Manage networks" or "Manage certificates".
4.2) Nothings happens.

However, the selection works for the search button and the switcher.

Comment 23

[Michael Bauer]

Re-opening, not fixed for me either.

Comment 24

[Carlo 'Carcarlo' Carmagnini]

With the recent build 20141113 I cannot reproduce comment 22. I had not erased user data when installing it. Everything seems to work fine. 

Firmware revision: flatfish_20141113-0106
OS Version: 2.2.0.0-prerelease
Build number: 20141113
Build Identifier: 20141113011509
Platform version: 36.0a1
Git commit info: 2014-11-12 16:29:28 d13f29ef

Comment 25

[Michael Bauer]

Build 20141114 seems to have resolved the issue for me. How about you CodingFree?

Comment 26

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

I'm also unable to reproduce comment 22. Please remember to flash data..

Comment 27

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Please feel free to ni? me again if there is more accurate STR with used FxOS + Device information.

And @Michael, if this can't be reproduced, please help to mark this as fixed. Thanks.

Comment 28

[Michael Bauer]

Given that different people reported different experiences a week ago when this was reported fixed, I was not about to rush in and close but seems like it HAS been fixed and no new reports so guess it's ok to close for now.