1089005 - Caret position is not changed by mouse click in input field when form-history autoComplete doropdown has been shown

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Alice0775 White]

This is annoying bug. 

Steps To Reproduce:
1. Focus input fields (which is enabled form-history autocomplete)
2. Type text so that form-history autocomplete suggestion pops up
3. Attempt change the caret position by clicking on the input field

Actual Results:
The caret position is not changed. You need click once more.

Expected Results:
The caret position should be changed where you clicked.

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/7e6cb031ed8f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131104081507
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/07ea7b11adef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131104082308
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7e6cb031ed8f&tochange=07ea7b11adef

Suspect:
07ea7b11adef	Neil Deakin — Bug 596723, Don't consume clicks outside of arrow panels by default, always consume the clicks on anchors of all popups, r=dao,neil

Comment 1

[Alice0775 White]

Attachment: datalist.html

Also, there is a similar problem in HTML5 datalist dropdown.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Not taking this into the Firefox Desktop backlog because we probably need to fix the widget itself or its event handling here.

Comment 3

[Matthew N. [:MattN]]

I think it may require a change in the popup code to handle autocomplete popups which would be in scope for someone like Neil.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Hmmm ok, let's leave that to Neil then. I think he is a good person to decide whether we should put it in the backlog.

Comment 5

[Neil Deakin]

Attachment: Patch

This patch changes the consume flag to have three states, 'don't consume', 'always consume' and 'consume on parent only'.

Comment 6

[Neil Deakin]

Attachment: Allow consume to be one of three states

Comment 7

[Neil Deakin]

Attachment: Allow consume to be one of three states, v2

This version is the same except also removes the manual manipulation of consumeoutsideclicks from autocomplete.xml which I don't think is needed any more. This fixes some issues with things working only some of the time.

Comment 8

[Neil Deakin]

Attachment: Allow consume to be one of three states, v2.1

This fixes a bug in the searchbar as it has its own content.

Comment 9

[Neil Deakin]

Comment on attachment 8544000 [details] [diff] [review]
Allow consume to be one of three states, v2.1

Maybe Dao can review this.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8544000 [details] [diff] [review]
Allow consume to be one of three states, v2.1

>-    consume = item->Frame()->ConsumeOutsideClicks();
>+    ConsumeOutsideClicksResult consumeResult = item->Frame()->ConsumeOutsideClicks();
>+    consume = (consumeResult == ConsumeOutsideClicks_True);
>+
>     // If the click was over the anchor, always consume the click. This way,
>     // clicking on a menu doesn't reopen the menu.
>-    if (!consume && pos) {
>+    if (consumeResult == ConsumeOutsideClicks_ParentOnly && pos) {
>       nsCOMPtr<nsIContent> anchor = item->Frame()->GetAnchor();

That comment doesn't seem quite accurate anymore

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/203e26771e77