1090843 - [Settings] Improve the time required for enabling the menu items of the root panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

There are a few bottle necks in the path of enabling the menu items.

- Too many modules for loading hardware information required in the module of the root panel.
- Too many query selectors in the init function of the root panel.
- There are many redundant setTimeouts in the panel navigation process.
- Some module required in main.js could be delay loaded.
- Radio related data could be retrieved earlier.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: WIP

Hi EJ, could you help check the patch? Thanks.

I used separated commits to address the issues listed above. In addition to that, I also implemented cached user actions as what we discussed offline.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8520451 [details]
WIP

looks nice to me (based on our offline discussions). f+

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Jared, may I know whether "findmydevice.ui.enabled" is still being used?

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hi Arthur,

That pref is leftover from when we weren't sure if FMD would ship in 2.0 or not. 

You can safely remove the data-show-name attribute (and the hidden attribute, too), as well as the 'findmydevice.ui.enabled' pref in build/config/common-settings.json.

Let me know if you need anything else,

Jared

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Cool, thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8520451 [details]
WIP

EJ, I addressed your comments. In addition, I modulalized startup.js to make it easier for unit testing. Could you help review it again? Thanks.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, I think this patch is almost there, can you rebase to latest master ?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Done rebasing!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8520451 [details]
WIP

r+ with one last nit. Thanks Arthur +++

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing, EJ!

master: 07e24e6f19271bedaa4bb0294e17eeefa9401997

Comment 11

[Florin Strugariu [:Bebe]]

This is breaking the Gaia-UI automated device tests

test_toggle_bluetooth_settings started to fail because of this:

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/.env/local/lib/python2.7/site-packages/marionette_client-0.8.4-py2.7.egg/marionette/marionette_test.py", line 264, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_bluetooth.py", line 30, in test_toggle_bluetooth_settings
bluetooth_settings = settings.open_bluetooth_settings()
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 134, in open_bluetooth_settings
self._tap_menu_item(self._bluetooth_menu_item_locator)
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 233, in _tap_menu_item
self._wait_for_parent_section_not_displayed(menu_item)
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/tests/python/gaia-ui-tests/gaiatest/apps/settings/app.py", line 228, in _wait_for_parent_section_not_displayed
lambda m: parent_section.location['x'] + parent_section.size['width'] == 0)
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 56, in wait_for_condition
Wait(self.marionette, timeout).until(method, message=message)
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.sanity/.env/local/lib/python2.7/site-packages/marionette_client-0.8.4-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.0 seconds

Device firmware (date) 	27 Nov 2014 22:58:22
Device firmware (incremental) 	eng.cltbld.20141128.015811
Device firmware (release) 	4.4.2
Device identifier 	flame
Gaia date 	27 Nov 2014 22:16:05
Gaia revision 	07e24e6f1927
Gecko build 	20141127223240
Gecko revision 	71da97c6ca1d
Gecko version 	36.0a1

http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.b2g-inbound.ui.functional.sanity/4264

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Let's fix the issue in bug 11059998.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Backed out the patch as it blocks QA tests.

revert: 400dfd7d81fcaa6f5032ba823a9348e4e16ed737

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Fix the bluetooth panel problem

EJ, I've added a new commit fixing the problem of navigating to the bluetooth panel. Could you help check it? Thanks.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8534222 [details]
Fix the bluetooth panel problem

Based on our offline discussion, let's fix the problem about the timing gap of loading low_priority_items & click events. 

Overall this patch is good to me ! Thanks Arthur.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8534222 [details]
Fix the bluetooth panel problem

EJ, would you mind review it again? The newly added commits should address the issue as what we've discussed, thanks.

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8534222 [details]
Fix the bluetooth panel problem

Thanks Arthur, r+ with last comment waiting to be confirmed on Github.

:)

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

:Bebe, I've create a new PR addressing the issue. Would you mind running the test with the new PR? Thanks!

Comment 19

[Florin Strugariu [:Bebe]]

I started a adhoc run on Jenkins:
test_settings_bluetooth:  http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/427

All settings tests: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/428/

Comment 20

[Florin Strugariu [:Bebe]]

Arthur All tests are passing as expected. Thanks for fixing this

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for helping Bebe.

master: 19f12e8d9308f8d7fde3b97c7f8b7b58bd876222