1092209 - Log viewer: Display TinderboxPrint output alongside job details

Status: VERIFIED FIXED

(Tree Management :: Treeherder: Log Viewer, defect, P4)

Description

[Armen [:armenzg]]

If you load this view:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2833982&repo=try
you won't see this information:
reftest 1733/120/78 (this shows up in the summary of a job when you click on it)

Could we please add it in the treeherder log viewer?
Thanks!

PS=I love the view!

Comment 1

[Ed Morley [:emorley]]

Yeah this would be handy :-)

Comment 4

[Jonathan French (:jfrench)]

So among 'universal' job properties we currently display:

(Job Details Panel + Job Details Tab)
Result, Job, Machine, Build(*), Job Name(*), Request(*), Start, End, Duration(*), InspectTask(*)

(Logviewer)
Result, Job, Machine, Start, End

...(*) are values we could consider adding to Logviewer if we wanted match them more closely. We'd like to add InspectTask to Logviewer for dupe bug 1179261. Ryan/Wes do you think we should add and match everything, or cherry pick additional values above for Logviewer?

If I recall correctly we had consciously chosen to omit some things in Logviewer.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

You could definitely do without the requested time. Duration can probably be skipped, too. Job Name would be nice to have.

Comment 6

[Ed Morley [:emorley]]

This bug is about adding the contents of TinderboxPrint to the log viewer. Most of the properties listed in comment 4 are not tinderboxprints.

Comment 7

[Ed Morley [:emorley]]

ie we want to add the things here:
https://treeherder.mozilla.org/api/project/mozilla-inbound/artifact/?job_id=11312936&name=Job+Info&type=json

Comment 8

[(not currently active) Ted Mielczarek]

From my dupe (bug 1102988), I asked for the links to blobber downloads. Things like minidumps are important when a log contains a crash, and we tend to paste logs into bugs, so clicking the log link should give you the ability to download things like that.

Comment 9

[Jonathan French (:jfrench)]

Could we append the printlines to the existing header block, and support scrolling of that container? And reduce the font size further so that by default some job details may completely fit in the current space. 

Alternately, we could put the current info into a 'Job info' tab (the default landing experience), with an adjacent 'Job details' tab for the printlines - supporting scrolling if the contents are large. I think would result in more mouse interaction though.

I kind of like the first one, not sure how everyone else feels.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

First sounds OK to me.

Comment 11

[Jonathan French (:jfrench)]

If I can get this working nicely I will assign myself :)

Comment 12

[Jonathan French (:jfrench)]

Getting closer, so assigning.

Comment 13

[Jonathan French (:jfrench)]

Attachment: PR798

Please see above PR for status and review.

Comment 14

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d0bb90a2eefd49deb31349a7a6f5caa1d71d5069
Bug 1092209 - Add tinderbox lines to logviewer

Comment 15

[Jonathan French (:jfrench)]

Marking fixed per above merge. If we need to add additional/separate content we could add it in a follow up bug I'm sure.

Comment 16

[Jonathan French (:jfrench)]

Verified fixed on stage.