Closed Bug 1092209 Opened 7 years ago Closed 6 years ago

Log viewer: Display TinderboxPrint output alongside job details

Categories

(Tree Management :: Treeherder: Log Viewer, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: armenzg, Assigned: jfrench)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
camd
: review+
Details | Review
If you load this view:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2833982&repo=try
you won't see this information:
reftest 1733/120/78 (this shows up in the summary of a job when you click on it)

Could we please add it in the treeherder log viewer?
Thanks!

PS=I love the view!
Yeah this would be handy :-)
OS: Linux → All
Hardware: x86_64 → All
Summary: Treeherder log viewer does not show summary → Log viewer: Display TinderboxPrint output alongside job details
Component: Treeherder → Treeherder: Log Viewer
Priority: -- → P3
Duplicate of this bug: 1102988
Priority: P3 → P4
Duplicate of this bug: 1179261
So among 'universal' job properties we currently display:

(Job Details Panel + Job Details Tab)
Result, Job, Machine, Build(*), Job Name(*), Request(*), Start, End, Duration(*), InspectTask(*)

(Logviewer)
Result, Job, Machine, Start, End

...(*) are values we could consider adding to Logviewer if we wanted match them more closely. We'd like to add InspectTask to Logviewer for dupe bug 1179261. Ryan/Wes do you think we should add and match everything, or cherry pick additional values above for Logviewer?

If I recall correctly we had consciously chosen to omit some things in Logviewer.
Flags: needinfo?(wkocher)
Flags: needinfo?(ryanvm)
You could definitely do without the requested time. Duration can probably be skipped, too. Job Name would be nice to have.
Flags: needinfo?(wkocher)
This bug is about adding the contents of TinderboxPrint to the log viewer. Most of the properties listed in comment 4 are not tinderboxprints.
From my dupe (bug 1102988), I asked for the links to blobber downloads. Things like minidumps are important when a log contains a crash, and we tend to paste logs into bugs, so clicking the log link should give you the ability to download things like that.
Could we append the printlines to the existing header block, and support scrolling of that container? And reduce the font size further so that by default some job details may completely fit in the current space. 

Alternately, we could put the current info into a 'Job info' tab (the default landing experience), with an adjacent 'Job details' tab for the printlines - supporting scrolling if the contents are large. I think would result in more mouse interaction though.

I kind of like the first one, not sure how everyone else feels.
First sounds OK to me.
Flags: needinfo?(ryanvm)
If I can get this working nicely I will assign myself :)
Blocks: 1182178
Getting closer, so assigning.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file PR798
Please see above PR for status and review.
Attachment #8637285 - Flags: review?(cdawson)
Attachment #8637285 - Flags: review?(cdawson) → review+
Marking fixed per above merge. If we need to add additional/separate content we could add it in a follow up bug I'm sure.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.