1093589 - [DSDS] Add test to receive phone call on both SIMs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Base user story: Bug 946874 - [DSDS][Dialer] Display receiving SIM on call screen

Let's receive a call on the first SIM, check that SIM1 appears, and do the same with SIM2

Comment 1

[Johan Lorenzo [:jlorenzo]]

Actually, there is no need to check SIM1 as it's already tested with test_dialer_receive_call.py

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Same test as test_dialer_receive_call.py, the only thing that changes is:
> self.testvars['local_phone_numbers'][1].replace('+', '')

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Actually, there is no need to wait for bug 1093583 anymore. What's your take on this guys?

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Except for the fact that we call the second SIM we don't do any checks that the call UI is reporting from what number the call comes... I would like to see a check in the test similar with:

https://github.com/mozilla-b2g/gaia/pull/25843/files#diff-2aff056a7c99b9f853d588feae7a015dR26

Comment 5

[Johan Lorenzo [:jlorenzo]]

Good point. I'll fix this.

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8520835 [details] [review]
Gaia PR

Clearing review until comment 4 is dealt with. Please re-request when ready.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Let's wait until bug 1093583 lands to add the assertion.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Like discussed yesterday, I ask Tamara for a review from the functional team's perspective. 

I added the checks on the "via SIM" label. Also, as test_dialer_receive_call.py is not executed during the DSDS job, I parameterized the test to run on both SIMs.

Comment 9

[Tamara Hills [:thills]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Hi Johan,

Tests look really good.  The only thing I might add as we discussed is to check the UI after the hangup in addition to the plivo states to makes sure that the UI reflects the change correctly and shows the "call ended" string.

Thanks,

-tamara

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Thanks for your review Tamara. After double-checking the code, we do a UI check during in the hangup function[1], we wait until the call screen disapears.

Also after trying to check the appearance of "Call Ended", I came across the following issue : the string is here for about a second. In other words, verifying this string may lead to some intermittent failures. Waiting for a more stable event (like the disappearance of the callscreen) sounds like a better option to me.

What do you think?

Comment 11

[Johan Lorenzo [:jlorenzo]]

I was wrong in comment 1, as we exclude all non-DSDS test cases with the current jobs set up. Hence, we should check for both SIMs.

Comment 12

[Viorela Ioia [:viorela]]

Comment on attachment 8520835 [details] [review]
Gaia PR

r+

Comment 13

[Florin Strugariu [:Bebe]]

Comment on attachment 8520835 [details] [review]
Gaia PR

All looks OK

Comment 14

[Tamara Hills [:thills]]

Comment on attachment 8520835 [details] [review]
Gaia PR

Hi Johan,

Looks good based on your comment that we are checking this in callscreen.hang_up.  Thanks for pointing that out.

-tamara

Comment 15

[Florin Strugariu [:Bebe]]

merged in master: https://github.com/mozilla-b2g/gaia/commit/a45b2cf7b5e5ddd90ef9a9d3171e3a1631c2b2a1