[DSDS] Add test to receive phone call on both SIMs

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
viorela
: review+
Bebe
: review+
thills
: review+
Details | Review
Base user story: Bug 946874 - [DSDS][Dialer] Display receiving SIM on call screen

Let's receive a call on the first SIM, check that SIM1 appears, and do the same with SIM2
Assignee: nobody → jlorenzo
QA Whiteboard: [fxosqa-auto-s3][fxosqa-auto-points=2]
Blocks: 946874
Depends on: 1094185
QA Whiteboard: [fxosqa-auto-s3][fxosqa-auto-points=2] → [fxosqa-auto-s4][fxosqa-auto-points=2]
QA Whiteboard: [fxosqa-auto-s4][fxosqa-auto-points=2] → [fxosqa-auto-from-s3][fxosqa-auto-s4][fxosqa-auto-points=2]
Actually, there is no need to check SIM1 as it's already tested with test_dialer_receive_call.py
Summary: [DSDS] Add test to receive phone call on both SIMs → [DSDS] Add test to receive phone call on second SIMs
Summary: [DSDS] Add test to receive phone call on second SIMs → [DSDS] Add test to receive phone call on second SIM
Posted file Gaia PR
Same test as test_dialer_receive_call.py, the only thing that changes is:
> self.testvars['local_phone_numbers'][1].replace('+', '')
Depends on: 1093583
Comment on attachment 8520835 [details] [review]
Gaia PR

Actually, there is no need to wait for bug 1093583 anymore. What's your take on this guys?
Attachment #8520835 - Flags: review?(viorela.ioia)
Attachment #8520835 - Flags: review?(florin.strugariu)
Attachment #8520835 - Flags: review?(drs.bugzilla)
Depends on: 1098279, 1098311, 1098317
No longer depends on: 1093583
Comment on attachment 8520835 [details] [review]
Gaia PR

Except for the fact that we call the second SIM we don't do any checks that the call UI is reporting from what number the call comes... I would like to see a check in the test similar with:

https://github.com/mozilla-b2g/gaia/pull/25843/files#diff-2aff056a7c99b9f853d588feae7a015dR26
Attachment #8520835 - Flags: review?(florin.strugariu) → review-
Good point. I'll fix this.
QA Whiteboard: [fxosqa-auto-from-s3][fxosqa-auto-s4][fxosqa-auto-points=2] → [fxosqa-auto-from-s3][fxosqa-auto-from-s4][fxosqa-auto-s5][fxosqa-auto-points=2]
Comment on attachment 8520835 [details] [review]
Gaia PR

Clearing review until comment 4 is dealt with. Please re-request when ready.
Attachment #8520835 - Flags: review?(drs.bugzilla)
Let's wait until bug 1093583 lands to add the assertion.
Depends on: 1093583
Comment on attachment 8520835 [details] [review]
Gaia PR

Like discussed yesterday, I ask Tamara for a review from the functional team's perspective. 

I added the checks on the "via SIM" label. Also, as test_dialer_receive_call.py is not executed during the DSDS job, I parameterized the test to run on both SIMs.
Attachment #8520835 - Flags: review?(thills)
Attachment #8520835 - Flags: review?(florin.strugariu)
Attachment #8520835 - Flags: review-
Comment on attachment 8520835 [details] [review]
Gaia PR

Hi Johan,

Tests look really good.  The only thing I might add as we discussed is to check the UI after the hangup in addition to the plivo states to makes sure that the UI reflects the change correctly and shows the "call ended" string.

Thanks,

-tamara
Attachment #8520835 - Flags: review?(thills) → review-
Comment on attachment 8520835 [details] [review]
Gaia PR

Thanks for your review Tamara. After double-checking the code, we do a UI check during in the hangup function[1], we wait until the call screen disapears.

Also after trying to check the appearance of "Call Ended", I came across the following issue : the string is here for about a second. In other words, verifying this string may lead to some intermittent failures. Waiting for a more stable event (like the disappearance of the callscreen) sounds like a better option to me.

What do you think?
Attachment #8520835 - Flags: review- → review?(thills)
Summary: [DSDS] Add test to receive phone call on second SIM → [DSDS] Add test to receive phone call on both SIMs
I was wrong in comment 1, as we exclude all non-DSDS test cases with the current jobs set up. Hence, we should check for both SIMs.
Comment on attachment 8520835 [details] [review]
Gaia PR

r+
Attachment #8520835 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8520835 [details] [review]
Gaia PR

All looks OK
Attachment #8520835 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8520835 [details] [review]
Gaia PR

Hi Johan,

Looks good based on your comment that we are checking this in callscreen.hang_up.  Thanks for pointing that out.

-tamara
Attachment #8520835 - Flags: review?(thills) → review+
merged in master: https://github.com/mozilla-b2g/gaia/commit/a45b2cf7b5e5ddd90ef9a9d3171e3a1631c2b2a1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.