Closed
Bug 1102667
Opened 10 years ago
Closed 9 years ago
texture_float extensions should imply either full or no color_buffer_float activation
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(4 files, 1 obsolete file)
7.63 KB,
text/html
|
Details | |
16.45 KB,
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
2.16 KB,
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
1.76 KB,
patch
|
Details | Diff | Splinter Review |
Right now, everyone seems to allow RTT with float textures when the relevant extension is active. The extensions say that they should implicitly activate their respective color_buffer_float extensions, though. That includes support for ReadPixels and renderbufferStorage.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8527083 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 2•10 years ago
|
||
I forgot to add the mochitest to the manifest.
Attachment #8527083 -
Attachment is obsolete: true
Attachment #8527083 -
Flags: review?(dglastonbury)
Attachment #8527113 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8527128 -
Flags: review?(dglastonbury)
Comment on attachment 8527113 [details] [diff] [review] 0001-Fix-float-texture-rb-fb-support.patch Review of attachment 8527113 [details] [diff] [review]: ----------------------------------------------------------------- It wasn't clear from the bug comment that the intention is to keep implicitly enabling float RTT. ::: dom/canvas/WebGLContextExtensions.cpp @@ +190,5 @@ > +WebGLContext::EnableSupportedExtension(JSContext* js, WebGLExtensionID ext) > +{ > + if (!IsExtensionEnabled(ext)) { > + if (!IsExtensionSupported(js, ext)) > + return nullptr; if (!IsExtensionSupported(js, ext)) return nullptr; if (!IsExtensionEnabled(ext)) EnableExtension(ext); return mExtensions[ext]; (I hate nesting)
Attachment #8527113 -
Flags: review?(dglastonbury) → review+
Attachment #8527128 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Dan Glastonbury :djg :kamidphish from comment #4) > Comment on attachment 8527113 [details] [diff] [review] > 0001-Fix-float-texture-rb-fb-support.patch > > Review of attachment 8527113 [details] [diff] [review]: > ----------------------------------------------------------------- > > It wasn't clear from the bug comment that the intention is to keep > implicitly enabling float RTT. As we sit currently, this disables float RTT. We should be getting the extension we need promoted to Community Approved soon. When this happens, color_buffer_float comes out from behind the draft flag, and will be picked up here. > > ::: dom/canvas/WebGLContextExtensions.cpp > @@ +190,5 @@ > > +WebGLContext::EnableSupportedExtension(JSContext* js, WebGLExtensionID ext) > > +{ > > + if (!IsExtensionEnabled(ext)) { > > + if (!IsExtensionSupported(js, ext)) > > + return nullptr; > > if (!IsExtensionSupported(js, ext)) > return nullptr; > > if (!IsExtensionEnabled(ext)) > EnableExtension(ext); > > return mExtensions[ext]; > > (I hate nesting) That's fine in general, but this is just a modification of a common pattern: EnsureFoo: if (!foo) foo = Foo return foo In our case, it's just not infallible. I think it's better how it is now.
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9336978bfa8c https://hg.mozilla.org/integration/mozilla-inbound/rev/b77b26c9b3b6 https://hg.mozilla.org/integration/mozilla-inbound/rev/b459d10124a8
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/da0a362dfe5d https://hg.mozilla.org/integration/mozilla-inbound/rev/d8081022e243 https://hg.mozilla.org/integration/mozilla-inbound/rev/80b929468f35 for android mochitest-1 orange: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4169671&repo=mozilla-inbound
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8fb97477d9e https://hg.mozilla.org/integration/mozilla-inbound/rev/d95090fbf3dc https://hg.mozilla.org/integration/mozilla-inbound/rev/6a871ae07d1f
Flags: needinfo?(jgilbert)
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e8fb97477d9e https://hg.mozilla.org/mozilla-central/rev/d95090fbf3dc https://hg.mozilla.org/mozilla-central/rev/6a871ae07d1f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•