1111961 - Developer mode support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[[:fabrice] Fabrice Desré]

Attachment: dev-mode.patch

Let's relax a bit the security model constraints.

Comment 1

[Alexandre Poirot [:ochameau]]

Instead of encouraging people to write apps that wouldn't work on production device,
shouldn't we just allow sideloading certified apps??

The security story is already quite complex to explain regarding devtools to not introduce yet another developer workflow :s

Note that I'm not really about opening constraints. I'm fine making bug 1100964 even easier to enable!
Why would sideloading certified apps be any different from enable certified permissions for any app?
I wish we could end up with just one "make my phone hackable" toggle.

Comment 2

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/edbd9d66d644

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Gaia patch - Add developer mode option in settings

For tracking, here is the patch that enables this from settings, using a simple prompt. We are defaulting this to true for eng builds on the lightsaber branch: https://github.com/mozilla-b2g/gaia/commit/587febfa24014acbcf5119349b9a82792b68b2c2

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/5e32a17bfbe6

Comment 5

[Doug Sherk (:drs) (inactive)]

I'm reopening this since we need it in some form on m-c.

Comment 6

[Julien Wajsberg [:julienw]]

Rebased patches: https://github.com/mozilla/gecko-dev/compare/master...julienw:developer-mode.patch

Comment 7

[[:fabrice] Fabrice Desré]

Attachment: dev-mode.patch

I didn't add the setting back. It's dangerous enough to only let that be turned on from WebIDE I think.

Comment 8

[[:fabrice] Fabrice Desré]

pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad66e20f03c9

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8590043 [details] [diff] [review]
dev-mode.patch

Review of attachment 8590043 [details] [diff] [review]:
-----------------------------------------------------------------

The code change looks good to me, but I'd prefer to get approval from Paul before landing this change.

::: dom/apps/PermissionsInstaller.jsm
@@ +178,5 @@
>        }
>      }
>      catch (ex) {
> +      dump("Caught webapps install permissions error for " + aApp.origin +
> +        " : " + ex + "\n");

nit: indention

Comment 10

[Paul Theriault [:pauljt] (no longer reading bugmail)]

So I'm a little unclear exactly what developer mode allows. From reviewing the code it looks like that it just relaxes the restrictions for importing and installing apps. Namely that:
- apps can have any role (including the reserved 'system' role)
- certified apps can be installed & "imported" (importexport.jsm)
- there's no restrictions on app types (i.e. hosted apps can be certified or privilegd)
- unsigned langpacks are allowed

So on face value I'm OK-ish with this, given that you can sideload certified apps anyways. The most worrying part for me is the foot-gun we add here for regular users - I assume this is post-2.2 but we probably want to think about how we protect this on production devices.  Comment 7 (ie don't have a setting for this, make it toggle-able by WebIDE only) sounds like a good control to me though, and make sure we warn the developers in WebIDE about the risk of flipping this mode.

Comment 11

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/integration/b2g-inbound/rev/56aa2a5662eb

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56aa2a5662eb