1113621 - Rename InstallPhaseEvent to ExtendableEvent

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Change Exposed=ServiceWorker for all ServiceWorker events.
Move Func= exposure check to ServiceWorker.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Rename InstallPhaseEvent to ExtendableEvent

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8539237 [details] [diff] [review]
Rename InstallPhaseEvent to ExtendableEvent

Review of attachment 8539237 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Bindings.conf
@@ +433,5 @@
>      },
>  },
>  
> +'ExtendableEvent': {
> +    'headerFile': 'ServiceWorkerEvents.h',

mozilla/dom/ServiceWorkerEvents.h ?

::: dom/workers/ServiceWorker.cpp
@@ +17,5 @@
> +
> +namespace mozilla {
> +namespace dom {
> +namespace workers {
> +

why do you don't like USING_WORKER_NAMESPACE? or BEGIN_WORKER_NAMESPACE?

@@ +28,5 @@
> +
> +  ServiceWorkerGlobalScope* scope = nullptr;
> +  nsresult rv = UnwrapObject<prototypes::id::ServiceWorkerGlobalScope_workers,
> +                             mozilla::dom::ServiceWorkerGlobalScopeBinding_workers::NativeType>(aObj, scope);
> +  return NS_SUCCEEDED(rv) && scope;

if the unwrapping succeeds, scope is always set:

return NS_SUCCEEDED(rv); should be enough.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Andrea Marchesini (:baku) from comment #2)
> ::: dom/workers/ServiceWorker.cpp
> @@ +17,5 @@
> > +
> > +namespace mozilla {
> > +namespace dom {
> > +namespace workers {
> > +
> 
> why do you don't like USING_WORKER_NAMESPACE? or BEGIN_WORKER_NAMESPACE?

At one point either khuey or bent told me not to use it :/

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Note to self to remove workers: True in Bindings.conf since it is not required when correct Exposed annotations are used.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed6d1902cc7

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I accidentally backed this out (instead of bug 1113631) in https://hg.mozilla.org/integration/mozilla-inbound/rev/961c75198f9d 

Relanded it in https://hg.mozilla.org/integration/mozilla-inbound/rev/fbf421e77962 as it wasn't supposed to be backed out, though.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fbf421e77962