1114774 - Black notification bar slides up when you trigger share overlay on Android L

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

When you "Add to Firefox" right now, the slide-up animation triggers a black bar that moves up the screen.

Let's fix this because I don't think it's intended :)

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Is this bug 1067425?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Nope, a black bar slides up for me on my Lollipop Nexus 5.

Comment 3

[Richard Newman [:rnewman]]

Huh, I see this on my N7. It's the title/notification bar; my guess is that the OS is rendering that as part of our activity, which we're animating up from the bottom.

Comment 4

[Aaron Train [:aaronmt]]

See this too.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1114774/mcomella

/r/4417 - Bug 1114774 - Hide the status bar on the share overlay. r=liuche

Pull down this commit:

hg pull review -r 161318fa1879e3d66b90ab248d3913ad7f9ddd10

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8570260 [details]
MozReview Request: bz://1114774/mcomella

https://reviewboard.mozilla.org/r/4415/#review3687

::: mobile/android/base/resources/values/styles.xml
(Diff revision 1)
> +        <item name="android:statusBarColor">@android:color/transparent</item>

Isn't this a 21+ only attribute? I can't find a reference to it in the Android docs (but then again, they are terrible for searching for xml attributes).

As long as it works and doesn't have any adverse effects on lower devices, I'm fine keeping it in, but maybe add a comment.
http://developer.android.com/reference/android/view/Window.html#setStatusBarColor%28int%29

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8570260 [details]
MozReview Request: bz://1114774/mcomella

https://reviewboard.mozilla.org/r/4415/#review3689

Ship It!

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/4415/#review3769

> Isn't this a 21+ only attribute? I can't find a reference to it in the Android docs (but then again, they are terrible for searching for xml attributes).
> 
> As long as it works and doesn't have any adverse effects on lower devices, I'm fine keeping it in, but maybe add a comment.
> http://developer.android.com/reference/android/view/Window.html#setStatusBarColor%28int%29

It is, but afaik unknown attributes will be ignored by the Android system, so this should be fine.

See [here](https://developer.android.com/training/material/theme.html) for docs on android:statusBarColor.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/ed304a94a050

NI self to uplift.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed304a94a050

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8570260 [details]
MozReview Request: bz://1114774/mcomella

Approval Request Comment
[Feature/regressing bug #]: Share overlay
[User impact if declined]:
  Users on Android L see the black system status bar translate onto the screen when opening the dialog.
 
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Extremely low - we just add a "android:statusBarColor" attribute which is set to transparent. Since we always show this over other activities, we don't need a status bar color for ourselves. Since we don't reference this attribute anywhere else, it would otherwise be unused.

[String/UUID change made/needed]: None

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Is it the same as Bug 1102221?

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #12)
> Is it the same as Bug 1102221?

I think so - do you find that bug 1102221 is fixed (probably in today's Nightly)?

Comment 15

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 5 (Android 5.0.1)
Build: Firefox for Android 39.0a1 (2015-03-05)

As you can see the video I've attached in bug 1102221: https://www.youtube.com/watch?v=cV7eghUEOoc&feature=youtu.be -> a black bar is triggered that moves up the screen; it is the same that Anthony mentions in this description. So, the two bugs are the same.

The issue is fixed in today's Nightly. No black bar is triggered.
I will mark status-firefox39 as verified.

Comment 16

[Teodora Vermesan (:TeoVermesan)]

Also see Bug 1102237, regarding Android 5.0 and share overlay: invoke context menu and choose "Add to Firefox" a page from about:home, the dialog  doesn't close as soon as the option is chosen. It becomes transparent  and only after that closes: http://goo.gl/YoCmtN

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0851168bbb9c

Comment 18

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 5 (Android 5.0.1)
Build: Firefox for Android 38.0a2 (2015-03-18)
No black bar slides up the screen when the share overlay "Add to Aurora" is displayed

Comment 20

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1114774 - Hide the status bar on the share overlay. r=liuche