1115892 - Crash reporter appears in a different language (Greek [el]) than Firefox and OS X (British English, [en-GB])

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Callum Macdonald]

Attachment: Screen Shot 2014-12-26 at 00.42.34.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

Start Firefox using a clean profile. I have a script that wipes the profile directory and runs a new Firefox instance with the `--no-remote` flag. The same behaviour happens on a clean profile or on my own profile.

Get the PID of firefox, and send a SIGABRT like `kill -6 XXX` on OSX where XXX is the PID.


Actual results:

The crash reporter launches in a language which is not English, a language with a different character set. Screenshot attached.


Expected results:

The crash reporter to lanch in English, the same language as I'm using in Firefox, OSX, etc.

Comment 1

[Loic]

Could you uninstall Firefox (only the program, not the profiles!) and download it (in EN version) from the Mozilla website.

After that, install the "crash me" add-on (https://code.google.com/p/crashme/) to see if the crash reporter is full English.

Comment 2

[Callum Macdonald]

Downloaded the English (British) version, deleted /Applications/Firefox.app/ (dragged to trash, emptied trash), then installed the new version, started Firefox and used both kill -6 and the crashme extension, same result in both cases. Same window as in the attached screenshot.

I'm starting Firefox (for the purpose of testing) like so:
/Applications/Firefox.app/Contents/MacOS/firefox-bin --no-remote -P clean

I have a profile called "clean" with an empty profile directory.

Comment 3

[ohnineunderscoreex]

Confirmed, i have the exact same issue.

Comment 4

[(Away)]

I opened the en-GB Mac package [1] and ran the crash reporter app. The "don't run this standalone" warning message was in Greek. That's language code 'el' and comes just before 'en-GB' so maybe there's some off-by-one issue in the language packaging?

[1] ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/34.0/mac/en-GB/Firefox%2034.0.dmg

Comment 5

[(Away)]

Pike can you help here?

Comment 6

[Francesco Lodolo [:flod]]

Looks like the build picked up files from the previous locale.

I checked Firefox 35.0b8.dmg en-GB and it's localized in English. Localization file is:
Firefox.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini

On 34 crashreporter.ini is in a different location, and it's indeed in Greek
Firefox.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini

I checked Italian and it's correctly localized even on 34.

We did have some issues with Crashreporter (bug 1080395), but in that case the file wasn't localized at all.

Comment 7

[Axel Hecht [:Pike]]

Let's move this over to release engineering, and see if they can dig up something in the logs.

CCing Gregory as he wants to make repacks more resilient, and can probably use the data for the failures.

Releng, is there anything interesting in the logs? Are there other candidates to look at? Where el and en-GB even made on the same slave in that order?

Comment 8

[Gregory Szorc [:gps]]

Is this fallout from the OS X packaging refactor to support Apple's new signing requirements?

Comment 9

[Axel Hecht [:Pike]]

I'd expect for it to happen in more locales if that was the case. I don't see it in German either, though, so there's at least 'de' and 'it' which are not affected. Those might be lucky picks in terms of build automation, too, though.

Comment 10

[Robert Strong (they/them - no direct email)]

Stephen, any idea as to what is going on with this bug?

Comment 11

[Stephen A Pohl [:spohl]]

Hmm, I don't have any good ideas besides what was already mentioned. I tend to agree with comment 9 at the moment. I can't think of a reason why v2 signing would be in play here, especially since the issue appears to be fixed in FF35 (per comment 6). There are no differences in v2 signing between FF34 and FF35 that I can think of.

Comment 12

[Rail Aliiev [:rail]]

http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/34.0.5-candidates/build1/logs/release-mozilla-release-34.1-macosx64_repack_3-bm84-build1-build0.txt.gz is the log where the repack was generated.

2 things make me suspicious:
1) el comes before en-GB, sounds like the build system uses the leftovers somehow
2) crashrepoter.ini is moved around by http://dxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.mk#119

Comment 13

[orbyss]

having the same issue. Tech guys at Firefox doesn't even have a clue. Suggested me to join a thread to get a solution. Problem 1 Souluion 0

Comment 14

[Rail Aliiev [:rail]]

Can someone check if this is still an issue in Firefox 35.0?

Comment 15

[(Away)]

Yes, still happens with 35.0

Comment 16

[Stephen A Pohl [:spohl]]

(In reply to David Major [:dmajor] (UTC+13) from comment #15)
> Yes, still happens with 35.0

Per comment 6 I was under the impression that Firefox 35 wasn't affected during beta. Could there be a difference between nightly/beta and release?

Comment 17

[Stephen A Pohl [:spohl]]

(In reply to Francesco Lodolo [:flod] from comment #6)
> Looks like the build picked up files from the previous locale.
> 
> I checked Firefox 35.0b8.dmg en-GB and it's localized in English.
> Localization file is:
> Firefox.app/Contents/Resources/crashreporter.app/Contents/Resources/
> crashreporter.ini
> 
> On 34 crashreporter.ini is in a different location, and it's indeed in Greek
> Firefox.app/Contents/MacOS/crashreporter.app/Contents/Resources/
> crashreporter.ini
> 

After reading this again, I noticed that the location for Firefox 35.0b8.dmg was incorrect. The crashreporter.app should always be under Firefox.app/Contents/MacOS, not Firefox.app/Contents/Resources. I'm surprised that the crashreporter worked at all in this case...

Comment 18

[Rail Aliiev [:rail]]

Related to bug 1080395 maybe?

Comment 19

[(Away)]

In Firefox 35.0.dmg I see crashreporter.ini in both of those paths.
This one is in English: Firefox.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini
And this one is in Greek: Firefox.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini

Comment 20

[Stephen A Pohl [:spohl]]

Attachment: Patch

This should fix it, but I've been unable to set up my system for localized builds. Robert, do you still have your setup from bug 1080395? Would you mind giving this a shot? If this get's your r+, I'll request a review from ted as well. Thank you!

Comment 21

[Robert Strong (they/them - no direct email)]

Comment on attachment 8548600 [details] [diff] [review]
Patch

My Mac is no longer booting :(

Comment 22

[Stephen A Pohl [:spohl]]

[Tracking Requested - why for this release]:

This makes for pretty bad UI for our en-GB users (see attachment 8541866 [details]). The fix (once confirmed) is tiny and risk is microscopic.

Comment 23

[Stephen A Pohl [:spohl]]

Comment on attachment 8548600 [details] [diff] [review]
Patch

:Pike, is there any way that you could confirm that this patch fixes the issue? Like I mentioned before, despite my best efforts I've been unable to set up my system for localized builds... :-/

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking and please keep me posted, if we have a verified fix I might consider this as a driver for a dot release since we really do need to keep collecting useful crash info from users.

Comment 25

[Axel Hecht [:Pike]]

Comment on attachment 8548600 [details] [diff] [review]
Patch

Review of attachment 8548600 [details] [diff] [review]:
-----------------------------------------------------------------

I can see how this helps. Not sure if this is the fix or a workaround.

Asking gps for a real review sounds like a good idea to me.

Comment 26

[Stephen A Pohl [:spohl]]

(In reply to Axel Hecht [:Pike] from comment #25)
> I can see how this helps. Not sure if this is the fix or a workaround.

Thanks, :Pike! I expect this to be the actual fix. We added code in bug 1080395 to move the localized crashreporter.ini to the proper place. Unfortunately, we missed the fact that this was in a |ifneq (en,$(AB))| block, which excludes en-GB even though it shouldn't have. It would be great to get confirmation that this actually fixes the issue and that en-US isn't negatively affected. If en-US misbehaves, I may have to put this in a |ifneq(en-US,$(AB_CD)| block.

Comment 27

[Lukas Blakk [:lsblakk] use ?needinfo]

On closer inspection it appears this is limited to a subset of locales (poss. only en-GB?) and so it's less urgent to be considered a driver for a dot release but we'll still track and wait for updates on how risky the fix is for consideration as a ride along in case of a dot release.

Comment 28

[ajf]

I have this, it's really weird. It's only by mere chance that I manage to click the right button when Firefox crashes. Well, I assume I clicked it.

Comment 29

[Gregory Szorc [:gps]]

Comment on attachment 8548600 [details] [diff] [review]
Patch

Review of attachment 8548600 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane.

Comment 30

[Stephen A Pohl [:spohl]]

I'm setting this to qawanted to make sure that we verify this in localized en-GB builds once uplifted. We should also make sure that en-US still works properly. I'll do this in mozilla-central myself before requesting uplift approval.

Comment 31

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f72f98ab8a3a

Comment 32

[Stephen A Pohl [:spohl]]

Comment on attachment 8548600 [details] [diff] [review]
Patch

It looks like nightlies don't have a localized crashreporter.app. We'll have to verify once uplifted.

Approval Request Comment
[Feature/regressing bug #]: Update lookup for crashreporter.ini for the new v2 bundle structure on OSX (bug 1055774).
[User impact if declined]: The crashreporter will display in Greek instead of English for en-GB locale.
[Describe test coverage new/current, TreeHerder]: n/a, localized crashreporter is unavailable for nightlies.
[Risks and why]: minimal
[String/UUID change made/needed]: n/a

Comment 33

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8548600 [details] [diff] [review]
Patch

Given that this fix can't be tested on Nightly, let's start by getting it on Aurora and testing there. Aurora+

Comment 34

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/26eeb4e56866

Comment 35

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f72f98ab8a3a

Comment 36

[orbyss]

Firefox update 35.0.1 
Crash Reporter is still in 'greek'

Comment 37

[Stephen A Pohl [:spohl]]

(In reply to orbyss from comment #36)
> Firefox update 35.0.1 
> Crash Reporter is still in 'greek'

Thanks. This is expected. The fix only just made it to Nightly (FF 38) and Aurora (FF 37) today and will need to be verified there before we can uplift to earlier versions.

Comment 38

[Stephen A Pohl [:spohl]]

I've verified the fix in today's aurora build. The crashreporter for en-GB is now correctly displayed in English. This appears ready for further uplift.

I ran the following tests to confirm:

Test 1:
Locale: en-GB
Build: 37.0a2 (2015-01-26)
Built from: https://hg.mozilla.org/releases/mozilla-aurora/rev/171f05f3d01c
Status: FAIL! The build prior to the patches in this bug reproduced the issue reported here.

Test 2:
Locale: en-GB
Build: 37.0a2 (2015-01-27)
Built from: https://hg.mozilla.org/releases/mozilla-aurora/rev/8f49a2fc3f0c
Status: PASS! Crashreporter correctly displays in English for en-GB after the fix in this bug.

Test 3:
Locale: en-US
Build: 37.0a2 (2015-01-27)
Built from: https://hg.mozilla.org/releases/mozilla-aurora/rev/8f49a2fc3f0c
Status: PASS! AFAICT, The patches for en-GB had no negative consequences for en-US locale.

Comment 39

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/38b5ab4af771

Comment 40

[Stephen A Pohl [:spohl]]

I just confirmed that this is also fixed in beta:

en-GB, built from https://hg.mozilla.org/releases/mozilla-beta/rev/5807991ef30a (prior to this fix)
> bug reproduces

en-GB, built from https://hg.mozilla.org/releases/mozilla-beta/rev/e3c1a6cbe4d3 (after the fix)
> bug is fixed

en-US, built from https://hg.mozilla.org/releases/mozilla-beta/rev/e3c1a6cbe4d3 (after this fix)
> no discernible regressions found

If we choose to uplift this any further, it appears ready for it.

Comment 42

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8548600 [details] [diff] [review]
Patch

Clearing the uplift flags as we are working on the 36 release now.