1117713 - [Flame][Calendar]Disable "All day" when creating an event,tap Save, it will pop up alert message "Something is wrong.Try again later."

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Elie]

[1.Description]:
[Flame][v2.2][Calendar]Disable "All day" when creating an event,tap Save,it will pop up alert message "Something is wrong.Try again later.".I can‘t create an event successfully.
Attach:logcat.txt  and VIDEO0204[1].mp4
Happen time:11:15

[2.Testing Steps]: 
1.Launch Calendar->switch to day view
2.Tap the "24" bar on the top of day view.
>>Then,"+" icon appears on the top of day view
3.Tap "+" icon to enter Add event view
4.Disable "All day event?"
5.Tap Save

[3.Expected Result]: 
5.It will not pop up alert message "Something is wrong.Try again later.", it should create an event successfully.

[4.Actual Result]: 
5.It will pop up alert message "Something is wrong.Try again later."

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        698e6e8a098cc060b26cd6f25171633c4c7e739d
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/57e4e9c33bef
Build-ID        20150103010205
Version         37.0a1

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: Free Test

Comment 1

[Elie]

Attachment: logcat.txt

Comment 2

[Elie]

Attachment: VIDEO0204[1].mp4

Comment 3

[Eric Chang [:ericcc] [:echang]]

Hi Gareth, Could you help with this, thanks.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Hrm this seems to be related to the fact that the start time is the same as the end time. I think Evan touched the modify event view code most recently, so he might be a good candidate to fix this (it seems low effort). I'll ask for 2.2? and we'll go over it next triage. Thanks Eric!

Comment 5

[Dylan Oliver [:doliver]]

triage: tracking+ for footgun. The idea for resolution here is to choose the default event time if the user unchecks the All Day option, which would be the top of the next hour (from current time) and a duration of one hour.

Comment 6

[GitHub Autolander Bot]

Attachment: [PullReq] millermedeiros:1117713-all-day-toggle-duration to mozilla-b2g:master

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8553874 [details] [review]
[PullReq] millermedeiros:1117713-all-day-toggle-duration to mozilla-b2g:master

LGTM with a single test nit. Thanks again for writing the test :)

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/70c3015a6e5b7504a7c4e66834483f63285958ff

Comment 11

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8553874 [details] [review]
[PullReq] millermedeiros:1117713-all-day-toggle-duration to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 999959 (that's when we allowed to create an all day event)
[User impact] if declined: user probably won't understand why he can't save the event since the error message is not descriptive (reason why he can't save it is because startTime == endTime)
[Testing completed]: maionette + manual testing
[Risk to taking this patch] (and alternatives if risky): low risk, changes are isolated
[String changes made]: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.2 uplift.

Comment 13

[Miller Medeiros [:millermedeiros]]

need to rebase because this bug actually depends on the work started on Bug 846940, so I'll provide a PR targeting v2.2 and containing both commits - the other commit is basically just to add the marionette tests and have a clean history.

Comment 14

[GitHub Autolander Bot]

Attachment: [PullReq] millermedeiros:1117713-all-day-toggle-v2.2 to mozilla-b2g:v2.2

Comment 15

[Miller Medeiros [:millermedeiros]]

landed on v2.2: https://github.com/mozilla-b2g/gaia/commit/65bcad0584faf15fca1864e89be779d3fa51449b

Comment 16

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nighty Flame 3.0 and 2.2 builds.

Results:  The event is created correctly.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150211002505
Gaia: 943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gecko: e614443583e7
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0