846940 - [B2G][Calendar] Creating an event while on a previous date results in defaulting to the current date

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[mlevin]

Description:
When on a previous date in the calendar, the User tries to create an event using the "+" symbol, results in the current date defaulting in the date fields.

Repro Steps:
1) Update Unagi to build ID: 20130225070200
2) Open Calendar.
3) Swipe to the previous month from the current month.
4) Tap one of the days in the previous month.
5) Tap the "+" in the top upper right part of the Unagi screen in order to add a new event in the past.

Expected:
Event screen to open showing the previous month's date the User chose in the date fields.

Actual:
Date fields in the Event screen show "today's" date instead of the date in the past that the User chose.

Repro frequency:
4/4

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6

Notes:
Test Suite Name: Calendar
UCID: calendar-026
Test Case ID#: 6168
Link to the test case: https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=6168

This is NOT a typical use case.
Workaround: When the Event screen opens click on the date field, and force the change in the past by changing the date

Comment 1

[Nick Davidson]

In reference to Description some additional information.

Test Case # 6168

UCID: calendar-026

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=6168

Comment 2

[Jason Smith [:jsmith]]

Received over email - Pauline wanted to work on this.

Comment 4

[PaulinePatron]

My patch proposition : https://github.com/mozilla-b2g/gaia/pull/8547

Comment 5

[Jason Smith [:jsmith]]

Attachment: Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8547

Comment 6

[Jason Smith [:jsmith]]

(In reply to PaulinePatron from comment #4)
> My patch proposition : https://github.com/mozilla-b2g/gaia/pull/8547

You want someone to review it? Give feedback on it?

Comment 7

[James Lal [:lightsofapollo]]

Nice work this is the right fix but you need to rebase on master (your PR will no longer apply) and make sure to remove any associated tests (if there are any).

Then we can land/uplift.

Comment 8

[PaulinePatron]

According to your comments , it's my new proposition patch (my modifications are rebased on master and I have removed any associated tests) : https://github.com/mozilla-b2g/gaia/pull/8598

 I will close my old pull request

(In reply to Jason Smith [:jsmith] from comment #6)
> (In reply to PaulinePatron from comment #4)
> > My patch proposition : https://github.com/mozilla-b2g/gaia/pull/8547
> 
> You want someone to review it? Give feedback on it?

Yes please :)

Comment 9

[Jason Smith [:jsmith]]

(In reply to PaulinePatron from comment #8)
> According to your comments , it's my new proposition patch (my modifications
> are rebased on master and I have removed any associated tests) :
> https://github.com/mozilla-b2g/gaia/pull/8598
> 
>  I will close my old pull request
> 
> (In reply to Jason Smith [:jsmith] from comment #6)
> > (In reply to PaulinePatron from comment #4)
> > > My patch proposition : https://github.com/mozilla-b2g/gaia/pull/8547
> > 
> > You want someone to review it? Give feedback on it?
> 
> Yes please :)

Okay. To ask for a review, you would normally add an attachment here that points to your github pull request. I already added it for you, so when you are ready for review, set the details in the attachment to set James or Kevin as a reviewer.

Comment 10

[PaulinePatron]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27426

Comment 11

[James Lal [:lightsofapollo]]

Comment on attachment 724142 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27426

Sorry for long delay!

I am going to land this when I get into the office Monday

Comment 12

[James Lal [:lightsofapollo]]

in master https://github.com/mozilla-b2g/gaia/commit/94634ca7eeb8f287b829c77942f0c1000bb628fa

Comment 13

[Miller Medeiros [:millermedeiros]]

this was reverted a long time ago (2013-04-04) and never got landed again. so I'm reopening it.

reverted: https://github.com/mozilla-b2g/gaia/commit/86137bd613dadcd670c1354685ce4a18fcff98ee

Comment 14

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27426

check if selected date is "today" instead of checking if `time < now`; also default the start time to 8AM based on Bug 1051752

Comment 15

[Miller Medeiros [:millermedeiros]]

Comment on attachment 724142 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27426

this PR broke the linter, is outdated and doesn't follow the rule that if event starts today it should default to next hour.

Comment 16

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8549736 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27426

Looks great thanks!

Comment 17

[Gareth Aye [:gaye] (back from PTO)]

Landed on gaia master https://github.com/mozilla-b2g/gaia/commit/3f57a3503c5748701bab089e21fc66a4afdcbb26

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1acb207a7c822ba3f081e233314d16bb66aec412

Comment 19

[Coler]

This issue has been verified successfully on Flame 2.2/3.0.
Attachment:Verify_Date.mp4

Flame 3.0:

Build ID               20150215010209
Gaia Revision          f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gaia Date              2015-02-13 13:13:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e0cb32a0b1aa
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150215.043133
Firmware Date          Sun Feb 15 04:31:43 EST 2015
Bootloader             L1TC000118D0

Flame 2.2:

Build ID               20150215002504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/62c80c92b39e
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150215.040852
Firmware Date          Sun Feb 15 04:09:03 EST 2015
Bootloader             L1TC000118D0

Comment 20

[Coler]

Attachment: Verify_Date.MP4