Mark virtual overridden functions as MOZ_OVERRIDE in WebRTC; r=jesup

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8544798 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in WebRTC

Review of attachment 8544798 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h
@@ +338,5 @@
>      return 0;
>    }
>  
>    virtual bool OnRecoveredPacket(const uint8_t* packet,
> +                                 int packet_length) OVERRIDE {

This is upstream code... and it's fixed in webrtc branch 40 which will land soon.  Please remove this from the patch.
Attachment #8544798 - Flags: review?(rjesup) → review+
(In reply to Randell Jesup [:jesup] from comment #2)
> ::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h
> @@ +338,5 @@
> >      return 0;
> >    }
> >  
> >    virtual bool OnRecoveredPacket(const uint8_t* packet,
> > +                                 int packet_length) OVERRIDE {
> 
> This is upstream code... and it's fixed in webrtc branch 40 which will land
> soon.  Please remove this from the patch.

Done!  Is there a bug number for the next WebRTC upstream code drop?  Thanks!
Flags: needinfo?(rjesup)
Bug 1109428
Flags: needinfo?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/19b240eda68e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(In reply to Randell Jesup [:jesup] from comment #4)
> Bug 1109428

Wrong bug? :)
Flags: needinfo?(rjesup)
bug 1109248 :-)
Flags: needinfo?(rjesup)
You need to log in before you can comment on or make changes to this bug.