1121691 - Implement module for handling observer notifications

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For various actions in our tests we have to wait until a specific or multiple observer notifications have been sent. Therefore we need a module which can wrap the following:

* Registration of a defined set of observer topics
* Executing a callback to triggering the wanted action
* Wait until all the registered topics have been fired
* Remove all registered observer topics

To make this happen we have to use execute_script or execute_async_script, at least for the waiting part. It's not that clear yet how to best handle the same observer topic multiple times for e.g. different observer targets. Registering topics separately causes a bit of overhead at least in Mozmill, so for performance reasons this needs to be investigated a bit.

Maybe it would be good to store the details of the notification in an object and let the client have access to it for evaluation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the implementation of the multiple sandbox feature on bug 1149618 we can finally start in using observer notifications for our tests. I won't have the time to work on it in a short term, but if someone else wants to work on it I can definitely give guidance. But I think it's too hard for a mentored bug.

Comment 3

[Benjamin Forehand Jr[:b4hand]]

Hey Henrik, any progress on this? Was only asking because looking through the puppeteer code I see it still as being needed to be worked on.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now there is no immediate need for it. Do you need anything specific?

Comment 5

[Benjamin Forehand Jr[:b4hand]]

Not right now. Thanks for that info!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't think that it makes sense to have a general observer handling module in firefox-puppeteer at this time. It's better to setup the necessary event and observer listeners via a Promise by the code which needs to wait for something specific. Maybe this bug can be re-evaluated later, but for now it's a wontfix.