1127006 - [META] IOS-1 - Firefox Ecosystem - Sharing

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P5)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

Comment 2

[Wesley Johnston (:wesj)]

Un-metaing this bug. While I think there will be additions and follow ups (adding screenshots, "Share image" in pages, etc.), the core feature is simple.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8562566 [details] [review]
Pull request

Wes, the screenshot is added already :-) Try to share some pages to Twitter. I compared the results between our app and Safari and the resulting screenshots are exactly the same. Looks like the extension framework downloads the page to grab screenshots.

I think the only thing that needs a quick fix is this:

I don't think the `selected.title ?? url` bit is correct. If it is good practice to attach the URL if a title is missing (i don't know if it is, we should check what safari does probably) then we should attach `url.absoluteString` instead. Otherwise we are just attaching two similar items of type `public.url` and the receiving extension would not see the difference between them.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8562566 [details] [review]
Pull request

I'm +ing but i think that title issue needs to be resolved before we merge.

Comment 5

[Jenn Chaulk (:jchaulk)]

Which Meta should those dependencies belong to then?  I'm marking this one done, and those aren't, they belong elsewhere in the dependency tree.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Yeah Wes. This one really can't be FIXED if the dependencies are not. How do we correct the links?

Comment 7

[Wesley Johnston (:wesj)]

I am not sure why those bugs are dependent on this one. i.e. why does "Supporting share extensions from other applications" depend on "Create a share extension to allow sharing into Firefox" or "Send tab"?

I revamped the other metabug (bug 1109663) that seemed to be specifically about Twitter/Facebook into a generic sharing one and we can hang these off there if you want (since it was fixed by this as well). But this was marked iOS-2 and that was iOS-1, so I regret doing that now.

This is not a meta bug. The dependencies here were wrong. I'm leaving them until I know where they go, but this bug did not depend on them.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Keep in mind that there are two distinct types of sharing:
1. I am inside Firefox and want to share to another app
2. I am in a different app and want to share to Firefox

Let's not use one meta bug for both concepts. Also, #2 has two sub components:
1. Add URL to the Firefox bookmarks or reading list
2. Send URL to a different device

The early mockups used two different UI entry points for these.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Looking at the pull request, this code is for #1 in comment 8, "I am inside Firefox and want to share to another app".

That is not what the title of this bug is about. It's about #2.

So I am changing the titles between this bug and bug 1109663 (the Twitter and Facebook part confused you).

Comment 12

[minati biswal]

Fir fox for iOS
Here https://onlineitguru.com/ios-online-training-placement.html

https://onlineitguru.com/tableau-online-training-placement.html