1129839 - [Flame][Dialer]The buttons of confirmation dialog are shown as "Action 1" and "Action 2".

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Sue]

Attachment: logcat_1712.txt

[1.Description]:
[Flame][Dialer]When you delete the record from call log, the buttons of confirmation message are shown as "Action 1" and "Action 2".
Found time:17:12
See attachment:video.MP4 and logcat_1712.txt

[2.Testing Steps]: 
1. Launch Phone app.
2. Make a call to "911".
3. Navigate to Call log.
4. Tap menu -> select the record -> tap Delete.
5. Long press at Home key and kill Phone app.
6. Repeat step 1and step 3-4.

[3.Expected Result]: 
4. The buttons of confirmation dialog should be shown as "Cancel" and "Delete".

[4.Actual Result]: 
The buttons of confirmation dialog are shown as "Action 1" and "Action 2".

[5.Reproduction build]: 
Flame 2.2 build:
Build ID               20150204002509
Gaia Revision          a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gaia Date              2015-02-04 00:41:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8669c26fd4a5
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.035932
Firmware Date          Wed Feb  4 03:59:42 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
occasionally Recurrence,3/5

[7.TCID]: 
Free Test

[8.Note]:
Once this issue has happened, it will shown "Action 1" and "Action 2" all the time.

Comment 1

[Sue]

Attachment: video.MP4

Comment 2

[Gabriele Svelto [:gsvelto]]

Looks pretty bad, is this happening only with 911? Is there an associate contact in the contacts list?

Comment 3

[William Hsu [:whsu]]

Hi, Sue,

Could you do a branch check (v3.0 & v2.1)?
Many thanks.

Comment 4

[Sue]

Hi William & Gabriele,
This issue can be repro on Flame 3.0, once you have called Emergency number, the buttons of confirmation dialog are shown as "Action 1" and "Action 2". But if you only called associate contact, the buttons of confirmation dialog are shown as "Cancel" and "Delete".
Rate:4/5

Flame 3.0 build:
Build ID               20150205010209
Gaia Revision          2b83a6d5d1185a438b5bbd287497ac2743b501db
Gaia Date              2015-02-04 21:30:59
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/34a66aaaca81
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150205.044014
Firmware Date          Thu Feb  5 04:40:24 EST 2015
Bootloader             L1TC000118D0

-------------------------------------------------------------------

This issue can not be repro on Flame 2.1, no matter what Emergency number and associate contact you have called, the buttons of confirmation dialog are shown as "Cancel" and "Delete".
Rate:0/20

Flame 2.1 build:
Build ID               20150205001711
Gaia Revision          17bf14f12e43043654498330d610d469b8b55e64
Gaia Date              2015-02-03 05:19:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/bdebcc47ec7a
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150205.035050
Firmware Date          Thu Feb  5 03:51:01 EST 2015
Bootloader             L1TC000118D0

Comment 5

[William Hsu [:whsu]]

Good Job! Add regression tag.

Comment 6

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression which happened in 2.2 and can really confuse an end user.

Gabriele, do you think a regression window is worth it?

Comment 7

[Gabriele Svelto [:gsvelto]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #6)
> [Blocking Requested - why for this release]: Regression which happened in
> 2.2 and can really confuse an end user.
> 
> Gabriele, do you think a regression window is worth it?

Definitely, it's probably also related to the other two bugs above.

Comment 8

[Doug Sherk (:drs) (inactive)]

This may be caused by bug 990369.

Comment 9

[Johan Lorenzo [:jlorenzo]]

I reverted the gaia commit in bug 990369 (086270b4022c25dab5266dfad5751987f4910a24) on top of the master branch, pushed to my Flame and tested again => the issue is still there.

Bug 1129765 and bug 1129339 might be dupes here but we don't have patches for them now.

Asking for a regression-window.

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

I've confirmed that this bug has the same window as Bug 1129765 and bug 1129339.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150126135000
Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac
Gecko: 38e4719e71af
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150126141259
Gaia: ef8b81a65a80fbfa019c5d70dd5916594837ebf7
Gecko: 3086135dda95
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac
Gecko: 3086135dda95

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: ef8b81a65a80fbfa019c5d70dd5916594837ebf7
Gecko: 38e4719e71af

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/b02ec9713e6de8d96c6954d2c0dfd0442b0656ac...ef8b81a65a80fbfa019c5d70dd5916594837ebf7

Caused by the patch for Bug 1102340.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Verify me once bug 1129339 lands.

Comment 13

[Wilfred Mathanaraj [:WDM]]

triage: remove nom as its resolved fixed

Comment 14

[Sue]

Attachment: verify_3.0.MP4

This issue has been verified successfully on Flame v3.0
STR:
1. Launch Phone app.
2. Make a call to "911".
3. Navigate to Call log.
4. Tap menu -> select the record -> tap Delete.
**The buttons of confirmation dialog shown as "Cancel" and "Delete".
See attachment:verify_3.0.MP4
Rate:0/5

Flame 3.0 build:
Build ID               20150214010227
Gaia Revision          f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gaia Date              2015-02-13 13:13:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a7c177546ca0
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150214.043959
Firmware Date          Sat Feb 14 04:40:10 EST 2015
Bootloader             L1TC000118D0

Comment 15

[Sue]

Leave "verifyme" for v2.2

Comment 16

[Sue]

Attachment: verify.png

This issue has been verified successfully on Flame v2.2
STR:
1. Launch Phone app.
2. Make a call to "911".
3. Navigate to Call log.
4. Tap menu -> select the record -> tap Delete.
**The buttons of confirmation dialog shown as "Cancel" and "Delete".
See attachment:verify.png
Rate:0/5

Flame 2.2 build:
Build ID               20150225002505
Gaia Revision          ca64f2fe145909f31af266b1730874051ba76c78
Gaia Date              2015-02-24 22:06:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.041814
Firmware Date          Wed Feb 25 04:18:25 EST 2015
Bootloader             L1TC000118D0