1132984 - Regression: Full-Screen video playback exhibits a status-bar shown in Android 4.0 and in 4.4+ a status-bar grey background shown

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently on full-screen, in Android 4.0 the status-bar will be shown and in Android 4.4+ a grey status bar will appear.

This is very similar to bug 1074924. Perhaps for a period of time it was fixed but it has regressed.

I can reproduce this on all channels. 

Currently with this alongside bug 1098390 makes our full-screen experience poor.

  
Steps to reproduce 

  http://people.mozilla.org/~atrain/mobile/tests/test.mp4
  Enter full-screen

  or 

  http://davidwalsh.name/demo/fullscreen.php

Comment 1

[Aaron Train [:aaronmt]]

I don't see .setStatusBarTintEnabled(!fullscreen) calls in code. Why/Where was this removed?

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> I don't see .setStatusBarTintEnabled(!fullscreen) calls in code. Why/Where
> was this removed?

Looks like it got refactored.

Is this called still? https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/util/ActivityUtils.java#19

Comment 3

[Teodora Vermesan (:TeoVermesan)]

Is this similar to Bug 1032179?

Comment 4

[Kevin Brosnan [:kbrosnan]]

Sounds similar to me. NI to Aaron

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #3)
> Is this similar to Bug 1032179?

Nope

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's try to address this sooner than later

Comment 7

[Aaron Train [:aaronmt]]

Video from my Nexus 6 (5.0.1): http://people.mozilla.org/~atrain/mobile/1132984.mp4

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I can repro on my N9, with Lollipop.

I can't repro on my N4/7 with 4.4.

Aaron, can you repro on any pre-Lollipop devices?

Comment 9

[Nikos Asimakis]

I can reproduce it on a Sony Xperia Sola (Android 4.0.4) and on a Samsung
Galaxy Tab 3 (Android 4.4.2), both updated to the latest firmware.

This bug didn't exist in Firefox 34. I also downgraded to Firefox 34 to
confirm it after experiencing it in Firefox 35. I tried Firefox Nightly too
and the regression is still there.

In case it matters both devices have hardware buttons (back, home, menu).

I am attaching screenshots.

Comment 10

[Nikos Asimakis]

Attachment: Fullscreen normal behavior (Firefox 34, Android 4.4).png

Comment 11

[Nikos Asimakis]

Attachment: Fullscreen regression (Firefox 35, Android 4.4).png

Comment 12

[Nikos Asimakis]

Attachment: Fullscreen video (Firefox 35, Android 4).png

Comment 13

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

I'm going to blame bug 1056002, which landed in 35.

Comment 14

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

The backout of bug 1056002 fixed this for me on my N9, the only device I can repro on (granted, it's Lollipop).

Nikos, this change should be in tomorrow's Nightly. Can you reproduce?

Comment 15

[Nikos Asimakis]

I just installed the latest nightly (39.0a1) and the bug is fixed in both devices. Fullscreen is working correctly again. Thank you!

When will the fix reach the stable release? Firefox 39 or earlier?

Comment 16

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

WORKSFORME by the backout of bug 1056002.

(In reply to Nikos Asimakis from comment #15)
> When will the fix reach the stable release? Firefox 39 or earlier?

We intend to fix this in Firefox 37+ (Beta).