Graphic buffer garbage shown and persists when entering full-screen (video/regular content) in Android 5.0 (Nexus 5)

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: jhugman)

Tracking

(Blocks: 2 bugs, {regression})

36 Branch
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 unaffected, firefox35 wontfix, firefox36+ wontfix, firefox37+ verified, firefox38+ fixed, firefox39 fixed, fennec+)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8522271 [details]
screenshot.png

See screenshot.

See video: http://youtu.be/g0ukpw7NGRU

--
Nexus 5 (Android 5.)
Nightly (11/13)
(Reporter)

Updated

4 years ago
Summary: Graphic buffer garbage shown and persists in video when entering full-screen in Android 5.0 (Nexus 5) → Graphic buffer garbage shown and persists when entering full-screen (video/regular content) in Android 5.0 (Nexus 5)
This looks to me like we are supposed to be drawing something in the area that the notification bar vacated and we're not. I bet Lucas knows what's up.
Flags: needinfo?(lucasr.at.mozilla)
Hmm, if the SurfaceView get resized to include that new space, maybe it's a gecko problem if we aren't drawing into that area.
The activity is always 'behind' the status bar now, we simply resize the root view when the statusbar is hidden/shown because we marked it with fitsSystemWindows.
Flags: needinfo?(lucasr.at.mozilla)
(Reporter)

Updated

4 years ago
status-firefox34: --- → unaffected
status-firefox35: --- → affected
Keywords: regression
(Reporter)

Comment 4

4 years ago
Last good revision: 50b689feab5f (2014-10-10)
First bad revision: f74ad36bb97b (2014-10-11)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=50b689feab5f&tochange=f74ad36bb97b

Probably 

03fd3fb2d48c	Lucas Rocha — Bug 1081153 - Consolidate BaseGeckoInterface/GeckoApp.setFullScreen() (r=mfinkle)

433cb9e553e1	Lucas Rocha — Bug 1074536 - Hide statubar tint whenever statusbar is hidden (r=mfinkle)

Updated

4 years ago
Assignee: nobody → lucasr.at.mozilla
tracking-fennec: ? → 35+
Lucas - Thoughts on this one?
(Reporter)

Comment 6

4 years ago
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Lucas - Thoughts on this one?

Needs a new assignee.
Assignee: lucasr.at.mozilla → nobody
Assignee: nobody → wjohnston
I looked at this a bit. The size change events don't fire on the LayerView when we switch to fullscreen, so it doesn't bother to invalidate this area. I'm not sure why.
Assignee: wjohnston → nobody
(Reporter)

Updated

4 years ago
status-firefox37: --- → affected
status-firefox38: --- → affected
[Tracking Requested - why for this release]: I know we shipped this but it is rather ugly and affects video playback quality.
tracking-firefox36: --- → ?
tracking-firefox37: --- → ?
tracking-firefox38: --- → ?
Assignee: nobody → jhugman
tracking-fennec: 35+ → +
Created attachment 8555382 [details]
Globe and Mail app graphics artifacts

Strangely, I've seen similar graphics artifacts on the top of the Globe and Mail app on a Nexus 5. Perhaps this is an OS related issue.
Tracking as this bug is about a visible graphics artifact.
tracking-firefox36: ? → +
tracking-firefox37: ? → +
tracking-firefox38: ? → +
James, any news on this? We are going to publish beta 6 today. The next window for mobile is beta 8 (go to build next Monday) Thanks
Flags: needinfo?(jhugman)
Wontfix for 36. It would be nice to have a fix for 37.
status-firefox35: affected → wontfix
status-firefox36: affected → wontfix
Blocks: 1135867
via bug 1135888, which I think is the same cause:

(In reply to Michael Comella (:mcomella) from comment #0)
> Perhaps a regression of bug 1056002 (status bar tint). I imagine the tinted
> status bar view is View.GONE when the status bar returns, causing no element
> to be drawn in that space until the tinted status bar view returns.
> 
> Perhaps related to bug 1135864 (fullscreen content does not draw over status
> bar).
This may be fixed by the backout of bug 1056002 - I cannot repro this so I cannot test. Instead, I had a grey status bar (with no content) at the top of the screen, which I attributed to bug 1132984.
Aaron, can you repro with this APK [1]? Should also be in tomorrow's Nightly.

[1] https://people.mozilla.com/~mcomella/apks/mcomella-1098390_01.apk
Flags: needinfo?(aaron.train)
(Reporter)

Comment 17

4 years ago
(In reply to Michael Comella (:mcomella) from comment #15)
> This may be fixed by the backout of bug 1056002 - I cannot repro this so I
> cannot test. Instead, I had a grey status bar (with no content) at the top
> of the screen, which I attributed to bug 1132984.

Ditto. No more 'garbage' but bottom grey bar and I see a status bar

Closing this one even though there are still exiting full-screen issues.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(aaron.train)
Resolution: --- → FIXED
Bug 1056002 was backed out of 37+. Marking 37+ as fixed.
status-firefox37: affected → fixed
status-firefox38: affected → fixed
status-firefox39: --- → fixed
Entering full-screen on http://people.mozilla.org/~nhirata/html_tp/elephants-dream.webm won't display  any graphic buffer garbage
Verified as fixed on:
Device: Nexus 7 (Android 5.0)
Build: 37 Beta 2
status-firefox37: fixed → verified
(Assignee)

Updated

3 years ago
Flags: needinfo?(jhugman)
You need to log in before you can comment on or make changes to this bug.