1098390 - Graphic buffer garbage shown and persists when entering full-screen (video/regular content) in Android 5.0 (Nexus 5)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

See screenshot.

See video: http://youtu.be/g0ukpw7NGRU

--
Nexus 5 (Android 5.)
Nightly (11/13)

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This looks to me like we are supposed to be drawing something in the area that the notification bar vacated and we're not. I bet Lucas knows what's up.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Hmm, if the SurfaceView get resized to include that new space, maybe it's a gecko problem if we aren't drawing into that area.

Comment 3

[Lucas Rocha (:lucasr)]

The activity is always 'behind' the status bar now, we simply resize the root view when the statusbar is hidden/shown because we marked it with fitsSystemWindows.

Comment 4

[Aaron Train [:aaronmt]]

Last good revision: 50b689feab5f (2014-10-10)
First bad revision: f74ad36bb97b (2014-10-11)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=50b689feab5f&tochange=f74ad36bb97b

Probably 

03fd3fb2d48c	Lucas Rocha — Bug 1081153 - Consolidate BaseGeckoInterface/GeckoApp.setFullScreen() (r=mfinkle)

433cb9e553e1	Lucas Rocha — Bug 1074536 - Hide statubar tint whenever statusbar is hidden (r=mfinkle)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Lucas - Thoughts on this one?

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Lucas - Thoughts on this one?

Needs a new assignee.

Comment 7

[Wesley Johnston (:wesj)]

I looked at this a bit. The size change events don't fire on the LayerView when we switch to fullscreen, so it doesn't bother to invalidate this area. I'm not sure why.

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: I know we shipped this but it is rather ugly and affects video playback quality.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Globe and Mail app graphics artifacts

Strangely, I've seen similar graphics artifacts on the top of the Globe and Mail app on a Nexus 5. Perhaps this is an OS related issue.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking as this bug is about a visible graphics artifact.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

James, any news on this? We are going to publish beta 6 today. The next window for mobile is beta 8 (go to build next Monday) Thanks

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Wontfix for 36. It would be nice to have a fix for 37.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via bug 1135888, which I think is the same cause:

(In reply to Michael Comella (:mcomella) from comment #0)
> Perhaps a regression of bug 1056002 (status bar tint). I imagine the tinted
> status bar view is View.GONE when the status bar returns, causing no element
> to be drawn in that space until the tinted status bar view returns.
> 
> Perhaps related to bug 1135864 (fullscreen content does not draw over status
> bar).

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This may be fixed by the backout of bug 1056002 - I cannot repro this so I cannot test. Instead, I had a grey status bar (with no content) at the top of the screen, which I attributed to bug 1132984.

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Aaron, can you repro with this APK [1]? Should also be in tomorrow's Nightly.

[1] https://people.mozilla.com/~mcomella/apks/mcomella-1098390_01.apk

Comment 17

[Aaron Train [:aaronmt]]

(In reply to Michael Comella (:mcomella) from comment #15)
> This may be fixed by the backout of bug 1056002 - I cannot repro this so I
> cannot test. Instead, I had a grey status bar (with no content) at the top
> of the screen, which I attributed to bug 1132984.

Ditto. No more 'garbage' but bottom grey bar and I see a status bar

Closing this one even though there are still exiting full-screen issues.

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

Bug 1056002 was backed out of 37+. Marking 37+ as fixed.

Comment 19

[Teodora Vermesan (:TeoVermesan)]

Entering full-screen on http://people.mozilla.org/~nhirata/html_tp/elephants-dream.webm won't display  any graphic buffer garbage
Verified as fixed on:
Device: Nexus 7 (Android 5.0)
Build: 37 Beta 2