1133142 - Downgrade "mTempFile not equal to mTargetFile" from assertion to warning

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

Attachment: downgrade assertion to warning

###!!! ASSERTION: mTempFile not equal to mTargetFile: 'Error', file /builds/slave/m-cen-osx64-d-0000000000000000/build/src/netwerk/base/nsFileStreams.cpp, line 967

This assertion is responsible for at least four intermittent orange bugs. I also hit it on almost half my startups (which per bug 341986 probably means it shouldn't even be a warning...).

Since this code is really old and nobody seems to be interested in debugging and fixing it, let's downgrade the assertion to a warning, so it doesn't keep triggering intermittent oranges and slowing down fuzzing.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8564426 [details] [diff] [review]
downgrade assertion to warning

Review of attachment 8564426 [details] [diff] [review]:
-----------------------------------------------------------------

I have no clue what can cause this. Rubberstamping, but we should open a bug to find an actual solution.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Bug 1134067 seems to be hitting this pretty easily right now, in case someone is interested in trying to debug. FWIW.

Comment 3

[Jesse Ruderman]

http://hg.mozilla.org/integration/mozilla-inbound/rev/659b843468a5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/659b843468a5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9ea4d014791b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8ffdc019a78