1138723 - Tablet does not inherit Material theme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I believe values-large-v11/themes.xml overrides values-v21/themes.xml.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1138723/mcomella

/r/4549 - Bug 1138723 - Move arrowPopupWidth to dimens (from theme attr). r=liuche
/r/4551 - Bug 1138723 - Remove GeckoBase theme in values-large-v11/ to inherit from Material on tablet. r=liuche

Pull down these commits:

hg pull review -r 2cd05437f22d7d2457da819043d9e8a8b1faf4fb

Comment 2

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4549/#review3771

::: mobile/android/base/resources/layout/arrow_popup.xml
(Diff revision 1)
> -    <ScrollView android:layout_width="?attr/arrowPopupWidth"
> +    <ScrollView android:layout_width="@dimen/arrow_popup_container_width"

This will actually be obsoleted by bug 1136469 which removes the arrow popup (and associated width) - you could save me the trouble of rebasing :P

Looks good though.

Comment 3

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4551/#review3773

Ship It!

::: mobile/android/base/resources/values-large-v11/themes.xml
(Diff revision 1)
> -        <item name="android:windowActionBar">false</item>

What is windowActionBar for? I see it in all the v11 resources, so make sure you don't need it for the v21 GeckoBase.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8572031 [details]
MozReview Request: bz://1138723/mcomella

https://reviewboard.mozilla.org/r/4547/#review3775

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Chenxia Liu [:liuche] from comment #3)
> What is windowActionBar for? I see it in all the v11 resources, so make sure
> you don't need it for the v21 GeckoBase.

Good call - filed bug 1139248.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/4551/#review3785

> What is windowActionBar for? I see it in all the v11 resources, so make sure you don't need it for the v21 GeckoBase.

Good call - filed bug 1139248.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Is this an r+? Sorry, it's a bit ambiguous.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8572031 [details]
MozReview Request: bz://1138723/mcomella

<finkle.gif>

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/75204e00b8cd
remote:   https://hg.mozilla.org/integration/fx-team/rev/ae4c0736cb3c

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8572031 [details]
MozReview Request: bz://1138723/mcomella

Approval Request Comment
[Feature/regressing bug #]: bug 1097337

[User impact if declined]:
  Users on tablet do not get android L features

[Describe test coverage new/current, TreeHerder]: None

[Risks and why]:
  We move a value that was specified with an Android attribute (match_parent) to our dimensions (pixel values) via a custom constant (also added in this patch). This is the first time we do such a thing and I'm a little suspicious of it because it's out of the norm, however, StackOverflow says it works and it appears to work in testing. Specifically, this value is used to determine the width of the doorhanger so in the worst case the width of the doorhanger is incorrect. Also, we may incorrectly change the style of tablet, but this is unlikely and low risk. 

[String/UUID change made/needed]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75204e00b8cd
https://hg.mozilla.org/mozilla-central/rev/ae4c0736cb3c

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8572031 [details]
MozReview Request: bz://1138723/mcomella

getting this into aurora so it gets to our beta audience for wider testing sooner.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54eb779dab7f
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f1a176fefaf

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1138723 - Move arrowPopupWidth to dimens (from theme attr). r=liuche

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1138723 - Remove GeckoBase theme in values-large-v11/ to inherit from Material on tablet. r=liuche