Closed
Bug 1138934
Opened 10 years ago
Closed 10 years ago
[OMTC] Black rectangle appears during animation on blocked GPU
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: alice0775, Assigned: bas.schouten)
References
Details
(Keywords: regression)
Attachments
(4 files)
851.76 KB,
image/png
|
Details | |
2.33 MB,
application/zip
|
Details | |
1.58 MB,
image/png
|
Details | |
1.24 KB,
patch
|
nical
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When I test Bug 1138863, I can see the graphic glitch. Black rectangle appears during animation. This problem happens on Windows BLOCKED GPU. Or set the following prefs user_pref("gfx.direct2d.disabled", true); user_pref("layers.acceleration.force-enabled", true); user_pref("layers.offmainthreadcomposition.enabled", true); Steps to reproduce: 1. Maximized 2. Open http://www.strobilanthes.com/ 3. Observe animation Actual Results: Black rectangle appears during animation Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b37955bdf1b6&tochange=99690880e8f5 Regressed by: 99690880e8f5 Bas Schouten — Bug 1035227: Upload partial surfaces when an upload region is specified. r=nical Graphics -------- Adapter Description: VMware SVGA 3D Adapter Drivers: vm3dum64 vm3dum vm3dgl64 vm3dgl Adapter RAM: 128 Device ID: 0x0405 Direct2D Enabled: Blocked for your graphics card because of unresolved driver issues. DirectWrite Enabled: false (6.3.9600.17415) Driver Date: 10-28-2013 Driver Version: 7.14.1.5026 GPU #2 Active: false GPU Accelerated Windows: 1/1 Direct3D 11 WARP (OMTC) Subsys ID: 040515ad Vendor ID: 0x15ad WebGL Renderer: Google Inc. -- ANGLE (VMware SVGA 3D Direct3D9Ex vs_3_0 ps_3_0) windowLayerManagerRemote: true AzureCanvasBackend: skia AzureContentBackend: cairo AzureFallbackCanvasBackend: cairo AzureSkiaAccelerated: 0
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Jeff was tracking an issue with a partial present as well, but, Bas, can you reproduce this? Given the driver bugs we're encountering that are having us block more of the combinations, we need to worry about this scenario, and should probably track this for uplifts.
Assignee: nobody → bas
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(bas)
Comment 3•10 years ago
|
||
I can reproduce this on my machine; can't reproduce the more encompassing bug 1138863.
Assignee | ||
Comment 5•10 years ago
|
||
On this screenshot we can see the layer that's causing the issue. There's a component alpha layer there that seems to have partially incorrect data.
Assignee | ||
Comment 6•10 years ago
|
||
I've confirmed the regressing bug was correctly identified. I don't fully understand why yet but it appears we simply don't send in the right region to be uploaded.
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8573030 -
Flags: review?(nical.bugzilla)
Comment 8•10 years ago
|
||
Comment on attachment 8573030 [details] [diff] [review] Make sure the white texture of a component alpha pair is always fully uploaded Review of attachment 8573030 [details] [diff] [review]: ----------------------------------------------------------------- Looks like a bit of an arbitrary hack/workaround, so a comment explaining why we need this and linking to this bug would be useful, I doubt I'll remember this in a few months.
Attachment #8573030 -
Flags: review?(nical.bugzilla) → review+
Comment 9•10 years ago
|
||
We'll definitely want an uplift request for this as soon as this lands and sticks. Let's make sure we don't forget to ask for it.
Flags: needinfo?(jmuizelaar)
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/713a86aa0c37
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Reporter | ||
Comment 11•10 years ago
|
||
I can still reproduce the glitch on the following build. https://hg.mozilla.org/integration/mozilla-inbound/rev/713a86aa0c37 Mozilla/5.0 (Windows NT 6.3; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0 ID:20150305173855 I've filed a new Bug 1140366.
Comment 12•10 years ago
|
||
Comment on attachment 8573030 [details] [diff] [review] Make sure the white texture of a component alpha pair is always fully uploaded Approval Request Comment [Feature/regressing bug #]: 1035227 (makes it worse) [User impact if declined]: Black rectangles flashing or remaining on the screen [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low risk, we just update more, though there may be a performance impact (we didn't see any on nightly.) [String/UUID change made/needed]:
Attachment #8573030 -
Flags: approval-mozilla-beta?
Attachment #8573030 -
Flags: approval-mozilla-aurora?
Comment 13•10 years ago
|
||
Comment on attachment 8573030 [details] [diff] [review] Make sure the white texture of a component alpha pair is always fully uploaded OK. Let's take this in Beta 4 and see if anything perf related shakes out. Beta+ Aurora+
Attachment #8573030 -
Flags: approval-mozilla-beta?
Attachment #8573030 -
Flags: approval-mozilla-beta+
Attachment #8573030 -
Flags: approval-mozilla-aurora?
Attachment #8573030 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
Flags: qe-verify+
Comment 16•10 years ago
|
||
I can also still reproduce this on Windows 7 x64, using the prefs specified by Alice in comment 0, with Firefox 37 Beta 4, latest Aurora 38, and latest Nightly 39. I provided more info in bug 1140366. I'm removing the qe-verify flag since additional verification will be done in bug 114036.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•