1147823 - Drag & drop xpi file , Install Add-on From File do not work on Nightly39

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

Steps To Reproduce:
1. Open Add-on Manager Ctrl+Shft+A
2. Attempt to install an add-on
   Drag & drop a xpi file
   Install "Install Add-on From File" from gear icon at the top of the Add-on Manager

Actual Results:
Install the addon fails


Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=690cfd1cf842&tochange=74cf6d15cfdd

Suspect: Bug 1139656

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Thanks for filing this

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 39. It would be good to have this land before Monday when we merge 39 to aurora. But if not we should uplift it later.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Liz Henry (:lizzard) from comment #3)
> Tracking for 39. It would be good to have this land before Monday when we
> merge 39 to aurora. But if not we should uplift it later.

Good to track but also worth noting that unless we get the additional UX changes for the new install flow we'll probably want to pref it off in 39, see bug 1148016

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8583780 [details] [diff] [review]
patch

Review of attachment 8583780 [details] [diff] [review]:
-----------------------------------------------------------------

So this means local file installs will have no security delay. That seems ok.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/250512664b21

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/250512664b21

Comment 9

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 39.0a1 (2015-03-26) using Windows 7 64-bit.

Verified fixed on Firefox 40.0a1 (2015-04-05) and Firefox 39.0a2 (2015-04-05) using Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5.