Closed Bug 1149830 Opened 5 years ago Closed 3 years ago
Do you think we need to worry about Firebug or somebody using any of this or is that too weird? I guess none of our own devtools even seem to use it.
We could check via addons mxr...
I found a user of nsIStackFrame::language, "Sepsis console": https://addons.mozilla.org/en-US/firefox/addon/sepsis-console/?src=search It uses it here: (requires AMO MXR access) https://mxr.mozilla.org/addons/source/431538/components/ConsoleAPI.js#481 It is similar to the use in our console code. That addon has a max version of 32, so maybe it doesn't work anyways. There's also a number of uses in the FirefoxOS 1.1 and 1.2 simulators, which seem to include the old Console code implemented in JS, but I think we can ignore that.
I'll dig into this a little.
Assignee: nobody → continuation
This is a little more yak-shave-y than I want to deal with right now.
Assignee: continuation → nobody
Apparently bug 1257919 part 4 killed the last user in Console.cpp. No one refers nsIStackFrame::language anymore.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 8893673 [details] Bug 1149830 - Remove nsIStackFrame::language. https://reviewboard.mozilla.org/r/164768/#review170398 Thanks! This looks fine to me, except for the WebIDL change which I don't know anything about. You also need a DOM peer review for that. Maybe you could ask Boris to take a look.
Attachment #8893673 - Flags: review?(continuation) → review+
Comment on attachment 8893673 [details] Bug 1149830 - Remove nsIStackFrame::language. r=bz for the WebIDL change.
Attachment #8893673 - Flags: review?(bzbarsky)
err... r?bz I mean. :)
Comment on attachment 8893673 [details] Bug 1149830 - Remove nsIStackFrame::language. https://reviewboard.mozilla.org/r/164768/#review170410 r=me
Attachment #8893673 - Flags: review?(bzbarsky) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/331cdaa5807b Remove nsIStackFrame::language. r=bz,mccr8
(In reply to Andrew McCreight [:mccr8] from comment #0) > do any addons use this? Stylish uses this and now it's broken.
You need to log in before you can comment on or make changes to this bug.