1150147 - [e10s] Leaking docshells during e10s debug runs of some social tests

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

These tests are leaking:
browser_addons.js
browser_blocklist.js
browser_social_marks.js
browser_SocialProvider.js

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: leaktest.js

This test illustrates a reproduction of the docshell leak.  You have to run mochitest-browser with --repeat 1 --e10s

This test does not use or enable any socialapi stuff

Comment 2

[Shane Caraveo (:mixedpuppy)]

test results with the attached test:

TEST-UNEXPECTED-FAIL | browser/base/content/test/social/browser_addtab.js | leaked 2 window(s) until shutdown [url = about:blank]
TEST-UNEXPECTED-FAIL | browser/base/content/test/social/browser_addtab.js | leaked 2 window(s) until shutdown [url = https://example.com/browser/browser/base/content/test/social/social_sidebar_empty.html]
TEST-INFO | browser/base/content/test/social/browser_addtab.js | windows(s) leaked: [pid = 16605] [serial = 11], [pid = 16605] [serial = 9], [pid = 16605] [serial = 12], [pid = 16605] [serial = 10]
TEST-UNEXPECTED-FAIL | browser/base/content/test/social/browser_addtab.js | leaked 1 docShell(s) until shutdown
TEST-INFO | browser/base/content/test/social/browser_addtab.js | docShell(s) leaked: [pid = 16605] [id = 5]

Comment 3

[Tracy Walker [:tracy]]

I was able to re-enable the test case browser_social_marks.js in bug 1192807. This bug was referenced in the skip-if.

Comment 4

[Andrew McCreight [:mccr8]]

I've fixed up some of these issues so somebody could retest.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

This seems to be fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1575411e068

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/106867397953

Comment 7

[:Felipe Gomes (needinfo for replies!)]

I ran browser_SocialProvider.js on a try push and it worked, so I enabled it. I saw that you had tried the other ones from comment 0, so I'll leave them with you.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/106867397953