Closed
Bug 1192807
Opened 8 years ago
Closed 8 years ago
Re-enable WFM browser chrome tests in test/social/
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: tracy, Assigned: tracy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.47 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
browser_social_contextmenu.js ref Bug 1072669 browser_social_flyout.js ref bug 1047603 browser_social_marks.js ref bug 1150147) browser_social_multiprovider.js ref Bug 1069162 and riding along from test/plugins/ browser_plugin_infolink.js ref bug 1160166 try run(s) https://treeherder.mozilla.org/#/jobs?repo=try&revision=633987920f5e current WIP has skip-if = e10s commented out. Does convention prefer this or the lines removed? Patch to be attached accordingly.
Assignee | ||
Comment 1•8 years ago
|
||
removed the skip-if lines instead of commenting them out
Attachment #8645882 -
Flags: review?(jmathies)
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 8645882 [details] [diff] [review] re-enable wfm test cases Once this sticks don't forget to close out any open bugs that were filed on the the disabled tests. Thanks!
Attachment #8645882 -
Flags: review?(jmathies) → review+
![]() |
||
Updated•8 years ago
|
Assignee: nobody → twalker
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #2) > Comment on attachment 8645882 [details] [diff] [review] > re-enable wfm test cases > > Once this sticks don't forget to close out any open bugs that were filed on > the the disabled tests. Thanks! Thanks and yes, I have them listed here for reference
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a922f1e1150b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 6•8 years ago
|
||
browser_plugin_infolink.js being re-enabled caused Win8 permafail in subsequent plugins tests. And browser_social_contextmenu.js is still failing intermittently on Linux. Re-disabled. https://treeherder.mozilla.org/logviewer.html#?job_id=4205453&repo=fx-team https://treeherder.mozilla.org/logviewer.html#?job_id=1999324&repo=mozilla-central
You need to log in
before you can comment on or make changes to this bug.
Description
•