1154415 - [Contacts][Facebook] All confirmation message screens that are seen within the contacts tab in dialer have placeholder text

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Contact Remove Facebook Logcat

Description:
If the user tries to delete contacts, or remove facebook information while they are accessing the contacts share activity via the dialer app, they will get an error message with placeholder text


Repro Steps:
1) Update a Flame to 20150414072436
2) Open Dialer app> Tap on contacts tab
3) Tap on gear Icon> Sign into facebook to import contacts
4) Select at least 1 contact> Tap update
5) Tap on the facebook Toggle


Actual:
"Confirmation message" appears in the header of the screen and "Action 2" appears on the red button


Expected:
"Remove all Facebook data?" appears in the header of the screen and "delete" appears on the red button

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150414072436
Gaia: c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 388f5861dc7d
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 10/10
See attached: Logcat, Video - https://youtu.be/Pzo8CdTpFA0

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue does NOT occur on Flame 2.2

"Remove all Facebook data?" appears in the header of the screen and "delete" appears on the red button

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150413002502
Gaia: cec00d643f517ffd96cde559cd3bbd43ab85816c
Gecko: 5005522fd68e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
UI regression of a core feature.

Requesting a window.

Comment 3

[Yeojin Chung [:YeojinC]]

b2g-inbound/ Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150410033337
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: b99b34dc9bd4
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150410044437
Gaia: 6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: 5a1b56e833f0
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: 5a1b56e833f0

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia:  6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: b99b34dc9bd4

https://github.com/mozilla-b2g/gaia/compare/749b6eb12c103f4119f1f85c72dbe7791684d8dc...6e403dbb863fb9ec41bd22b6583e2eff5045d78b

Caused by bug 1066347

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Zibi, can you take a look at this please? This might have been caused by the landing for bug 1066347.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

It may be a dupe of bug 1153917

Francesco, do you want to dupe it or keep that one as FTU and this one as Contacts?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Better to keep this one and take a look, just in case is not the same cause.

Thanks!

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

So, the reason for this bug is that dialer does not load two strings that it uses:

W/Communications( 1332): Content JS WARN: L10nError: "cleanFbConfirmMsg" not found in en-US in app://communications.gaiamobile.org/dialer/index.html#keyboard-view 
W/Communications( 1332):     at reportMissingEntity (app://communications.gaiamobile.org/dialer/gaia_build_defer_index.js:245:261)
W/Communications( 1332): Content JS WARN: L10nError: "remove" not found in en-US in app://communications.gaiamobile.org/dialer/index.html#keyboard-view 
W/Communications( 1332):     at reportMissingEntity (app://communications.gaiamobile.org/dialer/gaia_build_defer_index.js:245:261)

They are in contacts.properties which is not linked from dialer's index.html.

Comment 8

[Joshua Mitchell (Inactive)]

This actually seems to be affecting ANY confirmation messages in the Contact app when it is accessed through the Dialer app. Examples: Deleting any contacts, Adding the same contact as both ice contacts; they all result in the generic 'Confirmation Message' being given. I'm not writing those separately (yet) because it seems like they are all related to the same issue. 

If you agree, we might want to tweak the summary a bit to reflect this.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yup, seems like it's the same bug.

Comment 10

[Kevin Grandon :kgrandon]

I started looking into bug 1155084 so I will take this as well.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1154415_dialer_facebook_messages > mozilla-b2g:master

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8601616 [details] [review]
[gaia] KevinGrandon:bug_1154415_dialer_facebook_messages > mozilla-b2g:master

Etienne or Zibi - could either of you guys take a look at this?

The alternative would to be to create a shared l10n file, but it seems that there's not many strings that we would need to do this for (only stuff that's accessed from the shared javascript files for now). 

I think in the menatime handling these as a case-by-case basis might be the best bet. Let me know if you'd like me to explore an alternative approach though. Thanks!

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8601616 [details] [review]
[gaia] KevinGrandon:bug_1154415_dialer_facebook_messages > mozilla-b2g:master

Flod, does such duplication make sense to you?

Comment 14

[Francesco Lodolo [:flod]]

Comment on attachment 8601616 [details] [review]
[gaia] KevinGrandon:bug_1154415_dialer_facebook_messages > mozilla-b2g:master

Given that this involves only 2 strings, I think we can live with the duplication. Also, translation memory in tools should help localizers in keeping the consistency.

If the issue starts getting bigger and involving more strings, we might need to rethink the approach.

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8601616 [details] [review]
[gaia] KevinGrandon:bug_1154415_dialer_facebook_messages > mozilla-b2g:master

Thanks. I don't think it's really necessary to involve Etienne in the review here, so going to clear the request to save on review overhead.

Comment 16

[Kevin Grandon :kgrandon]

I'm curious to see what checkin-needed will do here since the review has been double-forwarded.

Comment 17

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 18

[Kevin Grandon :kgrandon]

Ok, we'll land manually for now.

In master: https://github.com/mozilla-b2g/gaia/commit/a07cd0da50afdc8fcc6b8a3a765da2507bce5c31

Comment 19

[Francesco Lodolo [:flod]]

(In reply to Kevin Grandon :kgrandon from comment #16)
> I'm curious to see what checkin-needed will do here since the review has
> been double-forwarded.

I could have told you that, my review doesn't really count much ;-)

Comment 20

[Kevin Grandon :kgrandon]

(In reply to Francesco Lodolo [:flod] (UTC+2) from comment #19)
> I could have told you that, my review doesn't really count much ;-)

Heh, well autolander has some logic to try to detect if a peer forwards a review to a non-peer, and it should allow it. I think it might just have a bug with the double forwarding.

Comment 21

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: "Remove all Facebook data?" appears in the header of the screen and "Remove" appears on the red button.
See attachment: verified_v3.0.3gp
Reproduce rate: 0/6


Device: Flame v3.0 build(Verified)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.192003
Firmware Date          Wed Jun 17 19:20:14 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Verified)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.192258
Firmware Date          Wed Jun 17 19:23:17 EDT 2015
Bootloader             HHZ12f

Comment 22

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.3gp