1157227 - redesign the "attachment details" page

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement, P2)

Description

[:glob ✱]

the 'attachment details' page is a ux nightmare.

here's what i'd like to do it:
- remove the attachment contents iframe completely
- remove the "edit as comment" feature
- always show the attachment metadata for editing
- make links to attachment actions (view, diff, review) much more prominent

Comment 1

[:glob ✱]

in order to allow users to easily view the source of security POC we should also add a "view as plain text", which forces a content-type of text/plain.

Comment 2

[:glob ✱]

some heavy reviewers still use the "edit as comment" feature, so we can't remove it; however it should be hidden by default.  the attachment metadata is more important.

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Is this still relevant?

Comment 4

[:glob ✱]

Yes, very much so.

(In reply to Byron Jones ‹:glob› 🎈 from comment #2)

some heavy reviewers still use the "edit as comment" feature, so we can't
remove it; however it should be hidden by default. the attachment metadata
is more important.

Since the move to Phabricator this is no longer relevant.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1157227 - redesign the "attachment details" page (#2186)

Comment 6

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/f7c487748aabc46c466ea7d784ec52b7767bd5fd