Closed
Bug 1158872
Opened 9 years ago
Closed 9 years ago
DevEdition theme has white titlebar on Windows (when window isn't maximized)
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ntim, Assigned: bgrins)
References
(Depends on 1 open bug)
Details
(Whiteboard: [polish-backlog][difficulty=easy][devedition-polish])
Attachments
(1 file)
1.03 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Screenshot : http://cl.ly/image/0343013i1r35
Reporter | ||
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=medium][devedition-polish]
Assignee | ||
Comment 1•9 years ago
|
||
We were speculating that it's related to the conversion to a lightweight theme (Bug 1148996). I haven't gotten to look closer to see if that's the case.
See Also: → 1148996
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 2•9 years ago
|
||
This fixes the issue by specifying the `accentcolor` option in the lightweight theme definition. The lightweight theme system seems to be copying over the accentcolor || "white" into the root element here: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/LightweightThemeConsumer.jsm#122
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8598206 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=medium][devedition-polish] → [devedition-40][difficulty=easy][devedition-polish]
Comment 3•9 years ago
|
||
Comment on attachment 8598206 [details] [diff] [review] lwt-devedition-color.patch Review of attachment 8598206 [details] [diff] [review]: ----------------------------------------------------------------- While we're here, can you file a bug to fix the menubar foreground color on Windows? Right now in a non-maximized window on win8 the dark/light theme causes the windows in-titlebar text (for the menubar) to be white/black, but it doesn't replace the background and so the white/black is sometimes unreadable depending on the window color. I expect xp + vista (classic and luna/aero) will have similar issues, esp. if the fog is applied differently because of the lwt-ness... (I forget how we do that off the top of my head) That's probably a dep/result of bug 1093820 + the lwt change.
Attachment #8598206 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 4•9 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/7882ac796e0f
Whiteboard: [devedition-40][difficulty=easy][devedition-polish] → [fixed-in-fx-team][devedition-40][difficulty=easy][devedition-polish]
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3) > While we're here, can you file a bug to fix the menubar foreground color on > Windows? Right now in a non-maximized window on win8 the dark/light theme > causes the windows in-titlebar text (for the menubar) to be white/black, but > it doesn't replace the background and so the white/black is sometimes > unreadable depending on the window color. I expect xp + vista (classic and > luna/aero) will have similar issues, esp. if the fog is applied differently > because of the lwt-ness... (I forget how we do that off the top of my head) Filed Bug 1159103
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7882ac796e0f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-40][difficulty=easy][devedition-polish] → [devedition-40][difficulty=easy][devedition-polish]
Target Milestone: --- → Firefox 40
Comment 7•9 years ago
|
||
Retriggers confirm that this "caused" the permafail in bug 1159150. Backed out. https://hg.mozilla.org/mozilla-central/rev/1ad65cbeb2f4
Status: RESOLVED → REOPENED
status-firefox40:
fixed → ---
Resolution: FIXED → ---
Target Milestone: Firefox 40 → ---
Assignee | ||
Comment 8•9 years ago
|
||
While Bug 1159150 gets sorted out, here is a try push in which I try to use `rgba(255, 255, 255, .001)` instead of transparent: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cd88b6a4e02 And new try push using the patch attached to the bug just for good measure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9201a95165f1
Assignee | ||
Comment 9•9 years ago
|
||
Try push after the fix from Bug 1159772 landed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82bc40d69754
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #9) > Try push after the fix from Bug 1159772 landed: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=82bc40d69754 There's a lot of orange there, but it all seems unrelated
Keywords: checkin-needed
Assignee | ||
Comment 11•9 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/604006b08454
Keywords: checkin-needed
Whiteboard: [devedition-40][difficulty=easy][devedition-polish] → [fixed-in-fx-team][devedition-40][difficulty=easy][devedition-polish]
https://hg.mozilla.org/mozilla-central/rev/604006b08454
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-40][difficulty=easy][devedition-polish] → [devedition-40][difficulty=easy][devedition-polish]
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=easy][devedition-polish] → [polish-backlog][difficulty=easy][devedition-polish]
You need to log in
before you can comment on or make changes to this bug.
Description
•