1158872 - DevEdition theme has white titlebar on Windows (when window isn't maximized)

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Screenshot : http://cl.ly/image/0343013i1r35

Comment 1

[Brian Grinstead [:bgrins]]

We were speculating that it's related to the conversion to a lightweight theme (Bug 1148996).  I haven't gotten to look closer to see if that's the case.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: lwt-devedition-color.patch

This fixes the issue by specifying the `accentcolor` option in the lightweight theme definition.  The lightweight theme system seems to be copying over the accentcolor || "white" into the root element here: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/LightweightThemeConsumer.jsm#122

Comment 3

[:Gijs (he/him)]

Comment on attachment 8598206 [details] [diff] [review]
lwt-devedition-color.patch

Review of attachment 8598206 [details] [diff] [review]:
-----------------------------------------------------------------

While we're here, can you file a bug to fix the menubar foreground color on Windows? Right now in a non-maximized window on win8 the dark/light theme causes the windows in-titlebar text (for the menubar) to be white/black, but it doesn't replace the background and so the white/black is sometimes unreadable depending on the window color. I expect xp + vista (classic and luna/aero) will have similar issues, esp. if the fog is applied differently because of the lwt-ness... (I forget how we do that off the top of my head)

That's probably a dep/result of bug 1093820 + the lwt change.

Comment 4

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/7882ac796e0f

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to :Gijs Kruitbosch from comment #3)
> While we're here, can you file a bug to fix the menubar foreground color on
> Windows? Right now in a non-maximized window on win8 the dark/light theme
> causes the windows in-titlebar text (for the menubar) to be white/black, but
> it doesn't replace the background and so the white/black is sometimes
> unreadable depending on the window color. I expect xp + vista (classic and
> luna/aero) will have similar issues, esp. if the fog is applied differently
> because of the lwt-ness... (I forget how we do that off the top of my head)

Filed Bug 1159103

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7882ac796e0f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Retriggers confirm that this "caused" the permafail in bug 1159150. Backed out.
https://hg.mozilla.org/mozilla-central/rev/1ad65cbeb2f4

Comment 8

[Brian Grinstead [:bgrins]]

While Bug 1159150 gets sorted out, here is a try push in which I try to use `rgba(255, 255, 255, .001)` instead of transparent:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cd88b6a4e02

And new try push using the patch attached to the bug just for good measure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9201a95165f1

Comment 9

[Brian Grinstead [:bgrins]]

Try push after the fix from Bug 1159772 landed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82bc40d69754

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #9)
> Try push after the fix from Bug 1159772 landed:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=82bc40d69754

There's a lot of orange there, but it all seems unrelated

Comment 11

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/604006b08454

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/604006b08454