1159316 - Update compose window theme to work with editable menulists

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[[e-mail]]

Bug 87987 wants to be able to turn the From field into an editable menulist.
On Windows, this mostly works, but the theme isn't quite right.
On Linux, this works, but the theme is somewhat corrupted.
On Mac, this doesn't really work at all.

Comment 1

[:aceman]

After applying bug 87987 I just see that the menulist has thicker border. But I do not see any double arrows as in the screenshot in bug 87987.

Comment 2

[[e-mail]]

That's because the screenshot was based on an earlier version of the patch without the CSS removals.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1159316.patch

This patch reverts the appearance back to pre bug 87987. The identityLabel on hover has the same appearance as the aw-menulist.

Josiah, you test this patch together with bug 87987. It needs only bug 1001535 applied first.

PS: Josiah isn't accepting reviews now. I'm waiting for review request.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8607186 [details] [diff] [review]
Bug1159316.patch

Resetting my reviews/bugs...

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug1159316.patch

Now with bug 87987 landed this patch is to revert to the old appearance before the bug.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8698063 [details] [diff] [review]
Bug1159316.patch

Review of attachment 8698063 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/554a35da7bc2 -> FIXED