Closed Bug 1160076 Opened 5 years ago Closed 5 years ago
Broken in-content preferences Search tab with browser
.search .show One Off Buttons = false
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:37.0) Gecko/20100101 Firefox/37.0 Build ID: 20150415140819 Steps to reproduce: I'm currently running Mac OS X 10.9.5 (Mavericks) and just installed Firefox 37.0.2. I installed add-ons for aesthetics and for functionality related to Web Development tools. I'm not sure how to perform a dump of any crucial information you may need to fix this issue--but here's a little background: 1) After the initial install of Firefox, going to the Preferences (Firefox -> Preferences [Cmd+,]) produced the typical window containing all settings. Nothing new here. 2) After installing all of the add-ons I needed (13 in total) as well as the Plugins I needed (5 in total), I took the time to configure the browser to my liking. It looks perfect. 3) After finishing my configuration, going back to the Preferences window creates a new tab, whether I use the keyboard shortcut or go through the context menu. Everything works fine with the exception of the 'Search' tab. Steps to reproduce: a. Go to Preferences [Cmd+,] or through context menu b. A new tab opens containing the Preferences (this was new for me, but impressed) c. Click on the 'Search' tab d. Click on the "Default Search Engine" dropdown e. Look at the "One-click search engines" table f. (Optional) Click on the "Restore Default Search Engines" buttons Actual results: Actual Results: [Steps a. and b. are skipped] c. The Search tab (on left), the tab itself disappears, but the settings still appear d. The dropdown is not populated, so an empty dropdown occurs e. The "One-click search engines" table is empty f. No effect (that I noticed) after clicking the "Restore Default Search Engines" button #NOTE: doing a refresh on the page returns the Search tab. Expected results: Expected Results: [Steps a. and b. are skipped] c. The Search tab (on left) shouldn't disappear d. The dropdown is populated with the current default; onClick shows all engines e. The "One-click search engines" table is populated with all installed Engines f. The default should be Yahoo, as this was the default engine after a fresh install
Related: bug 1157186. Do you have the same problem when you start Firefox in a brand new profile? https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles (In reply to Skyler Sully from comment #0) > I'm not sure how to perform a dump of any crucial information you may need 1. Type about:support into the location bar and press Enter. 2. Click the Copy Text to Cliboard button. 3. Paste the clipboard contents in the comment reply box here, but don't submit the reply just yet. 4. Type about:plugins into the location bar and press Enter. 5. Select everything and copy it to the clipboard. 6. Paste the clipboard contents at the end of the comment reply box, then submit the comment. > 3) After finishing my configuration, going back to the Preferences window > creates a new tab That shouldn't be happening until Firefox 38, which will be released around May 12. Did you at any point install a test version of Firefox like Beta or Nightly? If so, going back and forth between versions with the same profile probably mucked it up.
Component: Untriaged → Preferences
This can be caused by disabling one-click searches by setting browser.search.showOneOffButtons to false.
Video is corrupted when uploading to bugzilla. Here it is in gfycat: https://gfycat.com/ZealousAmpleAfricanelephant
(In reply to Fanolian from comment #2) > Created attachment 8600616 [details] > Video showing the disappearing of Search preference > > This can be caused by disabling one-click searches by setting > browser.search.showOneOffButtons to false. Turns out that this fixed the problem. However, I never disabled that config value, but it was indeed set to false (user set). I'm not sure if one of my plugins was responsible, but I need to do some additional testing as to how this happened. I need to reinstall Mac OS X anyway, so I'll be able to track down where the issue was invoked. I also have to try this from a different profile as was suggested previously.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 Build ID: 20150429135941 Steps to reproduce: 1. In about:config, set browser.search.showOneOffButtons to false. 2. In about:config, set browser.preferences.inContent to true (already the default in Firefox 38 and later). 3. Restart Firefox. 4. Open the Options/Preferences tab. 5. Click the Search category on the left. Actual results: Blank Default Search Engine drop-down menu. Disabled Provide Search Suggestions checkbox. Blank One-click Search Engines list. Non-functional Restore Default Search Engines button. (In reply to Fanolian from comment #2) > This can be caused by disabling one-click searches by setting > browser.search.showOneOffButtons to false. Thank you for tracking this down. (In reply to Skyler Sully from comment #5) > Turns out that this fixed the problem. However, I never disabled that config > value, but it was indeed set to false (user set). I'm not sure if one of my > plugins was responsible, but I need to do some additional testing as to how > this happened. I installed Classic Theme Restorer 1.3.2beta1 in Firefox 38, and it didn't touch either browser.search.showOneOffButtons or browser.preferences.inContent. So it — the latest version at least — doesn't break this functionality by default, though users can break it manually from the extension's preferences, Advanced category.
Status: UNCONFIRMED → NEW
Depends on: 1119250
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Summary: The Search tab disappears and doesn't display any installed search engines in the Preferences Tab (not the modal dialog box) for Mac OS X 10.9.5 → Broken in-content preferences Search tab with browser.search.showOneOffButtons = false
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8601435 - Flags: review?(gijskruitbosch+bugs)
This regressed with bug 1012223. A patch for bug 1119250 would be large enough that I would prefer not to uplift it.
Attachment #8601435 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8601435 [details] [diff] [review] Patch Not sure which approval flags are actually needed here. I think we want to get this low risk fix into 38.0.5, 39 and possibly also 38.1esr, as I would expect some corporate users to be more resistant to change, and so to be more likely to have flipped that pref. Approval Request Comment [Feature/regressing bug #]: regression caused by bug 1012223 [User impact if declined]: when browser.search.showOneOffButtons is false, a broken preference pane will be visible until it is selected. [Describe test coverage new/current, TreeHerder]: QA will verify [Risks and why]: low risk [String/UUID change made/needed]: none.
Hi Florian, can you provide a point value.
Iteration: --- → 40.3 - 11 May
Points: --- → 2
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 40.0a1 (buildID: 20150508030204).
Comment on attachment 8601435 [details] [diff] [review] Patch Let's take it for 38.0.5 & 38.1.0esr.
Attachment #8601435 - Flags: approval-mozilla-release?
Attachment #8601435 - Flags: approval-mozilla-release+
Attachment #8601435 - Flags: approval-mozilla-esr38?
Attachment #8601435 - Flags: approval-mozilla-esr38+
Attachment #8601435 - Flags: approval-mozilla-beta?
Attachment #8601435 - Flags: approval-mozilla-aurora?
Attachment #8601435 - Flags: approval-mozilla-aurora+
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 38.0.5 Beta 1 (buildID: 20150511143336).
A workaround for Firefox 38.0 users is to load the "old" Manage Search Engines dialog in a tab using: chrome://browser/content/search/engineManager.xul
You need to log in before you can comment on or make changes to this bug.