1160191 - [Browser] [SHB] - Browser ... menu is too short when SHB is enabled, allowing partial view of and interaction with underlying web page.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150430_0841.txt

Description:
The menu for browser is too short when the SHB is enabled. This creates a gap between the SHB area and the bottom of the menu that is about the same size as the SHB area (see screenshot). The user will be able to see the web-page they were on when accessing the menu. The user can still interact with this small section of the webpage while the menu is up; they can scroll and select options/buttons/links


Repro Steps:
1) Update a Flame to 20150430010201
2) Enable SHB in Developer Settings
3) Launch Browser and navigate to a web-page
4) Select the menu icon (... in upper left)

Actual:
Menu is too short, interactive gap at bottom

Expected:
No gap


Environmental Variables:
Device: Flame 3.0
Build ID: 20150430010201
Gaia: db8ea705c0fd1b1684807f5a8e837bb9a36a6f96
Gecko: 4b9b12c248dc
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 6/6

See attached: screenshot, logcat

Comment 1

[Joshua Mitchell (Inactive)]

This issue does NOT occur on Flame 2.2

Actual Results: Menu goes all the way to the SHB button area; no gap

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150429002501
Gaia: 1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gecko: d38ff4717f39
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Joshua Mitchell (Inactive)]

Attachment: 2015-04-30-10-33-19.png

Comment 3

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

Nominating to block on 3.0, Visible regression, poor UX

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150428090816
Gaia: 09ff6cc617c3f77865c746c6dbdd27caebf2b72b
Gecko: 7dc178cee12f
Version: 40.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken
Device: Flame
BuildID: 20150428095822
Gaia: 6e35b0948c42a4398b8a5916015de167121683a1
Gecko: 632a55ea8268
Version: 40.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko - issue does NOT repro
Gaia: 09ff6cc617c3f77865c746c6dbdd27caebf2b72b
Gecko: 632a55ea8268

Last Working Gecko First Broken Gaia - issue DOES repro
Gaia: 6e35b0948c42a4398b8a5916015de167121683a1
Gecko: 7dc178cee12f

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/09ff6cc617c3f77865c746c6dbdd27caebf2b72b...6e35b0948c42a4398b8a5916015de167121683a1

Caused by Bug 1155785.

Note that the patch for 1155785 was uplifted to v2.2 yesterday, so I've re-checked v2.2 and it is now affected.

Comment 5

[Gregor Wagner [:gwagner]]

Etienne, can you take a look?

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8602078 [details] [review]
[gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master

Quick one :)

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8602078 [details] [review]
[gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master

Seems fine to me. I'm a bit worried that there may be more cases of this though.

Comment 10

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/01526783f826428ddbd2a167678ac9e2fe412e2b

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8602078 [details] [review]
[gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1155785
[User impact] if declined: see Description
[Testing completed]: STR from the bugs + alerts/prompts/confirm with and without the SHB
[Risk to taking this patch] (and alternatives if risky): always feel bad marking a small css change as "low risk" because they never really are, but I'm confident :)
[String changes made]: none

Comment 13

[Yeojin Chung [:YeojinC]]

This issue still reproduces on Flame Master. 

Result: The menu fits to the screen in portrait mode. However, the menu still does not fully fit and shows the browser on right side when the device is set in landscape.

Bug 1162656 is filed for the issue.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150507064907
Gaia: 83b27f522642ea573c57e882657ab5c73d4b07f4
Gecko: 403e3c2380b5
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to Etienne Segonzac (:etienne) from comment #12)
> Comment on attachment 8602078 [details] [review]
> [gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): bug 1155785
> [User impact] if declined: see Description
> [Testing completed]: STR from the bugs + alerts/prompts/confirm with and
> without the SHB
> [Risk to taking this patch] (and alternatives if risky): always feel bad
> marking a small css change as "low risk" because they never really are, but
> I'm confident :)
haha, given comment #13, do we still want to land this ;) ?
> [String changes made]: none

Comment 16

[Etienne Segonzac (:etienne)]

(In reply to bhavana bajaj [:bajaj] from comment #15)
> (In reply to Etienne Segonzac (:etienne) from comment #12)
> > Comment on attachment 8602078 [details] [review]
> > [gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master
> > 
> > [Approval Request Comment]
> > [Bug caused by] (feature/regressing bug #): bug 1155785
> > [User impact] if declined: see Description
> > [Testing completed]: STR from the bugs + alerts/prompts/confirm with and
> > without the SHB
> > [Risk to taking this patch] (and alternatives if risky): always feel bad
> > marking a small css change as "low risk" because they never really are, but
> > I'm confident :)
> haha, given comment #13, do we still want to land this ;) ?

Ahah, this patch still makes things better, but it's only fixing the portrait case.
I'll send another patch for bug 1162656, it's easier to manage than follow ups (but we'll need both patches).

Comment 17

[bhavana bajaj [:bajaj]]

(In reply to Etienne Segonzac (:etienne) from comment #16)
> (In reply to bhavana bajaj [:bajaj] from comment #15)
> > (In reply to Etienne Segonzac (:etienne) from comment #12)
> > > Comment on attachment 8602078 [details] [review]
> > > [gaia] etiennesegonzac:bug-1160191 > mozilla-b2g:master
> > > 
> > > [Approval Request Comment]
> > > [Bug caused by] (feature/regressing bug #): bug 1155785
> > > [User impact] if declined: see Description
> > > [Testing completed]: STR from the bugs + alerts/prompts/confirm with and
> > > without the SHB
> > > [Risk to taking this patch] (and alternatives if risky): always feel bad
> > > marking a small css change as "low risk" because they never really are, but
> > > I'm confident :)
> > haha, given comment #13, do we still want to land this ;) ?
> 
> Ahah, this patch still makes things better, but it's only fixing the
> portrait case.
> I'll send another patch for bug 1162656, it's easier to manage than follow
> ups (but we'll need both patches).

alright, sounds good.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/449867a1a3dbd3d62a8cc026bf107709850fdbb2

Comment 19

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest 3.0 build.  Leaving the verifyme keyword so this can be checked on 2.2 when a build is made that has it.

Actual Results: The ... menus fits the whole screen in landscape and in portrait now.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150512010209
Gaia: 6089234ace8b294a8feef064387604bae16254e3
Gecko: 502e1a5e722f
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 20

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v2.2 by the STR in Comment 0.

Actual results: The "..." menu view fits the whole screen in landscape and in portrait mode.
See attachment: verified_v2.2.png
Reproduce rate: 0/5

Device: Flame v2.2 build(Pass)
Build ID               20150513002507
Gaia Revision          e048df68f6f4853b5826a8816e143d95258149de
Gaia Date              2015-05-12 19:10:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0e6b4aab2b94
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150513.041549
Firmware Date          Wed May 13 04:15:58 EDT 2015
Bootloader             L1TC000118D0

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.png