Closed
Bug 1164208
Opened 9 years ago
Closed 9 years ago
Update Pocket code to latest version (May 11th code drop)
Categories
(Firefox :: Pocket, defect, P1)
Firefox
Pocket
Tracking
()
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
41.15 KB,
patch
|
jaws
:
review+
Dolske
:
approval-mozilla-aurora+
Dolske
:
approval-mozilla-beta+
Dolske
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1163360 +++ https://github.com/Pocket/Firefox/pull/72 Updates: Fixed error handling response (bug 1163316) Fixed http links that should have been https Added learn more link ab test Fixed unicode error message handling Fixed suggested tags missing on first use (bug 1163614)
Assignee | ||
Comment 1•9 years ago
|
||
- Didn't add the README.md from Github - Note that github diffs show the stuff already included in m-c via bug 1163576
Assignee: nobody → dolske
Attachment #8604969 -
Flags: review?(jaws)
Comment 2•9 years ago
|
||
FYI: I did a diff between this patch and the code from the PR and found no merge issues. The code looks clean. (Haven't actually tested the build yet)
Comment 3•9 years ago
|
||
Comment on attachment 8604969 [details] [diff] [review] Patch v.1 Review of attachment 8604969 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/pocket/panels/css/signup.css @@ +359,5 @@ > .pkt_ext_signup_ru .signup-btn-firefox .text { > left: 15px; > } > +.pkt_ext_signup_de .signup-btn-firefox .logo, > +.pkt_ext_signup_es .pkt_ext_signupdetail_hero .signup-btn-firefox .logo, pdehaan asked 2 days ago on Github why _es has an extra selector on here while the others don't. Either I'm terrible at Github or he didn't get a response. We should double check with Nate before landing this.
Attachment #8604969 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8604969 [details] [diff] [review] Patch v.1 [Triage Comment] a+ for aurora/beta/release: required for Pocket launch in 38.0.5.
Attachment #8604969 -
Flags: approval-mozilla-release+
Attachment #8604969 -
Flags: approval-mozilla-beta+
Attachment #8604969 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•9 years ago
|
||
(aurora currently closed) https://hg.mozilla.org/releases/mozilla-beta/rev/f0d036466718 https://hg.mozilla.org/releases/mozilla-release/rev/55c04a549775
https://hg.mozilla.org/mozilla-central/rev/dcb6eeab33d1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
QA Contact: andrei.vaida
Updated•9 years ago
|
Flags: qe-verify+
Comment 9•9 years ago
|
||
Reproduced and verified fixed bug 1163316 and bug 116361: Pocket premium correctly shows the premium panel first, respectively, [object Object] no longer displayed for Suggested tags. Verification done based on comment 0, with 38.0.5 beta 2 (Build ID: 20150514163436), across the following platforms: Windows 7 x64, Ubuntu 14.04 x64 and Mac OS X 10.9.5
You need to log in
before you can comment on or make changes to this bug.
Description
•