1163360 - Update Pocket code to latest version (May 9th code drop)

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Justin Dolske [:Dolske]]

+++ This bug was initially created as a clone of Bug #1163265 +++

Update to today's small code drop to tweak some layout issues with localized strings.

https://github.com/Pocket/Firefox/pull/69/files

(This patch will be on top of the last update, bug 1163265, which hasn't landed just yet.)

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Updated from PR.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8603783 [details] [diff] [review]
Patch v.1

Review of attachment 8603783 [details] [diff] [review]:
-----------------------------------------------------------------

tmpl.is had hard coded "Pocket" in the markup that should be coming from the localization files. 

Reluctant r+ because of that. An issue needs to be filed on the pocket side.

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 8603783 [details] [diff] [review]
Patch v.1

[Triage Comment]

Required for Pocket / 38.0.5 release.

Comment 4

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/042cb568f4dd

Comment 5

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ffe0f4d8ce77
https://hg.mozilla.org/releases/mozilla-release/rev/f4179577249b

Comment 7

[Andrei Vaida [:avaida]]

Confirmed fixed through the Regression testing performed on 38.0.5b1-build2 (20150511143336), using Windows 7 (x64), Windows 8.1 (x86), Mac OS X 10.9.5 and Ubuntu 14.04 (x64). All issues found were filed and will be treated separately.