Closed Bug 1163360 Opened 4 years ago Closed 4 years ago

Update Pocket code to latest version (May 9th code drop)

Categories

(Firefox :: Pocket, defect, P1)

defect
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox38.0.5 --- verified
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1163265 +++

Update to today's small code drop to tweak some layout issues with localized strings.

https://github.com/Pocket/Firefox/pull/69/files

(This patch will be on top of the last update, bug 1163265, which hasn't landed just yet.)
Attached patch Patch v.1Splinter Review
Updated from PR.
Assignee: nobody → dolske
Attachment #8603783 - Flags: review?(jaws)
Status: NEW → ASSIGNED
Flags: qe-verify?
Flags: firefox-backlog+
Comment on attachment 8603783 [details] [diff] [review]
Patch v.1

Review of attachment 8603783 [details] [diff] [review]:
-----------------------------------------------------------------

tmpl.is had hard coded "Pocket" in the markup that should be coming from the localization files. 

Reluctant r+ because of that. An issue needs to be filed on the pocket side.
Attachment #8603783 - Flags: review?(jaws) → review+
Comment on attachment 8603783 [details] [diff] [review]
Patch v.1

[Triage Comment]

Required for Pocket / 38.0.5 release.
Attachment #8603783 - Flags: approval-mozilla-release+
Attachment #8603783 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ffe0f4d8ce77
https://hg.mozilla.org/releases/mozilla-release/rev/f4179577249b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Duplicate of this bug: 1162005
Flags: qe-verify? → qe-verify+
QA Contact: andrei.vaida
Blocks: 1164208
Confirmed fixed through the Regression testing performed on 38.0.5b1-build2 (20150511143336), using Windows 7 (x64), Windows 8.1 (x86), Mac OS X 10.9.5 and Ubuntu 14.04 (x64). All issues found were filed and will be treated separately.
Blocks: 1164419
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.