Closed
Bug 1166122
Opened 9 years ago
Closed 9 years ago
[regression] call tree is super broken
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: vporof)
References
Details
Attachments
(2 files)
385.71 KB,
image/png
|
Details | |
1.25 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Not even sure how else to explain how broken this is.
Reporter | ||
Comment 1•9 years ago
|
||
Introduced via Bug 1165045, sending back to you VP It seems its just a column issue, but looks like the script names are all sorts of messed up on yahoo.com, will handle in another bug, so not as bad as i thought
Assignee: nobody → vporof
Summary: [regression] call tree is super broken. → [regression] call tree columns are not lined up
Assignee | ||
Comment 3•9 years ago
|
||
I liked the previous title more. Totally not my fault though. I'm not even making excuses here.
Summary: [regression] call tree columns are not lined up → [regression] call tree is super broken
Assignee | ||
Updated•9 years ago
|
Blocks: perf-tool-papercuts
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8607640 -
Flags: review?(jsantell)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8607640 [details] [diff] [review] call-tree-broked.patch Review of attachment 8607640 [details] [diff] [review]: ----------------------------------------------------------------- #programming #superbroken
Attachment #8607640 -
Flags: review?(jsantell) → review+
Reporter | ||
Updated•9 years ago
|
Whiteboard: [fixed-in-fx-team]
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5404dd0fda63
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify+
Comment 8•9 years ago
|
||
Comment on attachment 8607640 [details] [diff] [review] call-tree-broked.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8607640 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a8957c73dde7
status-firefox40:
--- → fixed
Comment 10•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 11•9 years ago
|
||
Comment on attachment 8607640 [details] [diff] [review] call-tree-broked.patch Change approved to skip one train as part of the spring campaign.
Attachment #8607640 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•9 years ago
|
||
Reproduced the initial bug with Nightly 41.0a1 (2015-05-18). Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. The "Call Tree" detailed view is now displaying data properly.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•