1167218 - Colored edges visible in titlebar, even when maximized

Status: RESOLVED DUPLICATE of bug 1169911

(Firefox :: Theme, defect, P1)

Description

[Peter Henkel [:Terepin]]

Attachment: screenshot.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150520030205




Expected results:

In new build 10122 they added colored edge around the whole window. Unfortunately that edge is still visible in title bar on both sides even when FX is maximized.

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

This is the kind of obvious glitch that we should be avoiding from day 1.
Can we get this into 39?

Comment 4

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #3)
> This is the kind of obvious glitch that we should be avoiding from day 1.
> Can we get this into 39?

Depends how hacky we want to get.

It seems this is caused by the window's native appearance. If you add margins to the things inside the window, the border shows larger there, too. There's no CSS that's actively putting it there.

I haven't really managed to figure out what part of our UI is causing white to be drawn over it at the top.

One way to fix this is to nuke the -moz-appearance of the window and hardcode the background to white in CSS. I don't know what other issues that causes, but I expect there will be some. The correct way to fix it would be to fix the code that does whatever -moz-appearance does in this context. That is probably partially dependent on attributes like chromemargin. Setting that to 0,1,1,1 seems to help a bit but not a lot? CC'ing some of the widget/graphics folks who know about Windows in case they have ideas.

Comment 5

[Edo Karabas]

FYI in the Google Chrome (v44) it's visible in the same way as in Firefox. Most likely it's just another Windows 10 preview bug.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Eddward from comment #5)
> FYI in the Google Chrome (v44) it's visible in the same way as in Firefox.
> Most likely it's just another Windows 10 preview bug.

lets wait for rtm then.

Comment 7

[Peter Henkel [:Terepin]]

(In reply to Eddward from comment #5)
> FYI in the Google Chrome (v44) it's visible in the same way as in Firefox.
> Most likely it's just another Windows 10 preview bug.

Chrome has it even worse. Window edges were changed completely, while in Win8 they just changed style. Both Chrome and FX are using hacks to get rid of inner edge of Aero Glass windows. But this hack isn't needed anymore. Maybe if we remove that, it will get fixed?

Comment 8

[:Gijs (he/him)]

Yeah, there are adjustments we can make ourselves here.

Comment 9

[:Gijs (he/him)]

The patch from bug 1169911 should address this.

Comment 10

[:Gijs (he/him)]

Going to just dupe this because that's going to make tracking easier.