1170285 - Define lint.xml config for "base" sub-project

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This bug should define some lint.xml configuration files (e.g. [1]) to reduce the number of errors at this point and fix the remaining issues.

There are currently 1134 outstanding issues. :)

[1]: https://groups.google.com/forum/#!topic/adt-dev/xWSUOAq3RCM

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: base:lint result (as of a4bb8b6b0acd)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note to self: also audit use of @SuppressLint.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander

Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander

While it might seem like a good idea to disable all of the checks we don't
currently pass, Intellij uses the same lint configuration file as the
command-line invocation and so we'll be more likely to write in new errors by
disabling some checks.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #0)
> and fix the remaining issues.

Simplified this - bug 1170884.

(In reply to Michael Comella (:mcomella) from comment #2)
> Note to self: also audit use of @SuppressLint.

bug 1170886.

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614469 [details]
MozReview Request: Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander

https://reviewboard.mozilla.org/r/9969/#review8835

I feel like this won't actually be used, even by |mach gradle build|.  I feel like we'd need a symlink from $OBJDIR/mobile/android/gradle/base/lint.xml -> $SRCDIR/mobile/android/gradle/base/lint.xml.  Like at https://dxr.mozilla.org/mozilla-central/source/mobile/android/mach_commands.py?from=mobile/android/mach_commands.py#132

However, if this does work, do it.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Add lint.xml config file to base sub-project

While it might seem like a good idea to disable all of the checks we don't
currently pass, Intellij uses the same lint configuration file as the
command-line invocation and so we'll be more likely to write in new errors by
disabling some checks.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614469 [details]
MozReview Request: Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander

Added symlinking to the other config file.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6f9c88367517

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f9c88367517