Closed Bug 1170886 Opened 5 years ago Closed 5 years ago

Audit use of @SuppressLint annotation (and XML equivalent)

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

We should do this before we start fixing all of the existing issues in (bug 1170884) because we'll be adding these same annotations.
Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander
Attachment #8614487 - Flags: review?(nalexander)
Bug 1170886 - Replace use of NewApi suppression with @TargetApi. r?nalexander

TargetApi is specific, and preferred.
Attachment #8614488 - Flags: review?(nalexander)
Bug 1170886 - Remove unnecessary InlinedApi suppression. r?nalexander
Attachment #8614489 - Flags: review?(nalexander)
Summary: Audit use of @SuppressLint annotation (and XML) equivalent → Audit use of @SuppressLint annotation (and XML equivalent)
Comment on attachment 8614487 [details]
MozReview Request: Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander

https://reviewboard.mozilla.org/r/9989/#review8841

This needs to happen in the android-sync repo, unfortunately.
Attachment #8614487 - Flags: review?(nalexander)
Comment on attachment 8614488 [details]
MozReview Request: Bug 1170886 - Replace use of NewApi suppression with @TargetApi. r?nalexander

https://reviewboard.mozilla.org/r/9991/#review8845

I have never understood this annotation.  @TargetApi was only added in 16.  Does this cause problems?  If not, roll on.
Attachment #8614488 - Flags: review?(nalexander) → review+
Comment on attachment 8614489 [details]
MozReview Request: Bug 1170886 - Remove unnecessary InlinedApi suppression. r?nalexander

https://reviewboard.mozilla.org/r/9993/#review8847

Technically we should upstream this; but I don't think we're *downstreaming* changes, so roll on.
Attachment #8614489 - Flags: review?(nalexander) → review+
(In reply to Nick Alexander :nalexander from comment #7)
> I have never understood this annotation.  @TargetApi was only added in 16. 
> Does this cause problems?  If not, roll on.

It was my understanding that this annotation is only used by the linter and not used at runtime, thus accessible for development on any version as long as you target a high enough platform level - I'll throw up a try push to make sure.
Attachment #8614487 - Attachment is obsolete: true
There are a few other items from the android-sync repo in the mxr results but they appear to be fixed in the android-sync repo - I'm going to wager it's an issue with keeping the repos synced.
Whiteboard: [leave-open]
Attachment #8615624 - Flags: review?(nalexander) → review+
Status: NEW → ASSIGNED
Whiteboard: [leave-open]
You need to log in before you can comment on or make changes to this bug.