1170886 - Audit use of @SuppressLint annotation (and XML equivalent)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We should do this before we start fixing all of the existing issues in (bug 1170884) because we'll be adding these same annotations.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We currently do not use tools:ignore in XML: https://mxr.mozilla.org/mozilla-central/search?string=tools%3Aignore&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander

Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170886 - Replace use of NewApi suppression with @TargetApi. r?nalexander

Bug 1170886 - Replace use of NewApi suppression with @TargetApi. r?nalexander

TargetApi is specific, and preferred.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170886 - Remove unnecessary InlinedApi suppression. r?nalexander

Bug 1170886 - Remove unnecessary InlinedApi suppression. r?nalexander

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Still TODO - two remaining suppressions in FXA:

https://mxr.mozilla.org/mozilla-central/search?string=%40SuppressLint&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614487 [details]
MozReview Request: Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander

https://reviewboard.mozilla.org/r/9989/#review8841

This needs to happen in the android-sync repo, unfortunately.

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614488 [details]
MozReview Request: Bug 1170886 - Replace use of NewApi suppression with @TargetApi. r?nalexander

https://reviewboard.mozilla.org/r/9991/#review8845

I have never understood this annotation.  @TargetApi was only added in 16.  Does this cause problems?  If not, roll on.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614489 [details]
MozReview Request: Bug 1170886 - Remove unnecessary InlinedApi suppression. r?nalexander

https://reviewboard.mozilla.org/r/9993/#review8847

Technically we should upstream this; but I don't think we're *downstreaming* changes, so roll on.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Nick Alexander :nalexander from comment #7)
> I have never understood this annotation.  @TargetApi was only added in 16. 
> Does this cause problems?  If not, roll on.

It was my understanding that this annotation is only used by the linter and not used at runtime, thus accessible for development on any version as long as you target a high enough platform level - I'll throw up a try push to make sure.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ddfd219cbfd

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3323917a06d3

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Try looks good.

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Fix DefaultLocale annotation

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/dff7128718c4
https://hg.mozilla.org/integration/fx-team/rev/cc28adc3328d

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There are a few other items from the android-sync repo in the mxr results but they appear to be fixed in the android-sync repo - I'm going to wager it's an issue with keeping the repos synced.

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/51066bde3d7a

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dff7128718c4
https://hg.mozilla.org/mozilla-central/rev/cc28adc3328d
https://hg.mozilla.org/mozilla-central/rev/51066bde3d7a

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dff7128718c4
https://hg.mozilla.org/mozilla-central/rev/cc28adc3328d
https://hg.mozilla.org/mozilla-central/rev/51066bde3d7a

Comment 19

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170886 - Specify correct Locale in String.toUpperCase and remove @SuppressLint. r?nalexander

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cde286271f7

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5cde286271f7