1173729 - Update generic close icon and new tab button icon on Windows 10

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

Notably, this will make the tab close button larger for touch-friendliness.

Comment 1

[Dão Gottwald [:dao]]

needinfo for the new images

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: close-tab-win10.png

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 4

[Dão Gottwald [:dao]]

We also need inverted variants.

And we need the new-tab button icons. Let me know if you prefer handling those in a separate bug.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: close-tab-inverted-win10.png

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: newtab-win10.png

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 9

[Stephen Horlander [:shorlander]]

Attachment: newtab-inverted-win10.png

Comment 10

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch (WIP)

Comment 12

[Dão Gottwald [:dao]]

Attachment: patch

I updated the generic close button, not just the tab close button, since we want touch-friendliness everywhere.

Also made this change on Windows 8 since touch screens are more common there than for older Windows versions.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8635300 [details] [diff] [review]
patch

Review of attachment 8635300 [details] [diff] [review]:
-----------------------------------------------------------------

untested but the patch looks good. r=me

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ac6f2fb6777e

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac6f2fb6777e

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 8635300 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics and touch-friendliness
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: increasing the icon size for the generic close-icon class is a little bit scary, but this important enough and has baked long enough that we should uplift it
[String/UUID change made/needed]: none

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8635300 [details] [diff] [review]
patch

This fix has been on m-c for 5 days. Let's get it into beta7 and see if any issues shake out. Beta+ Aurora+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0d42bfee9ce7

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4389f43032c7

Comment 20

[Cornel Ionce [:noni] [Hubs QA]]

Confirming this fix on Windows 10 64-bit using:
- latest Nightly, build ID: 20150726030217;
- latest Aurora, build ID: 20150726004010;
- Firefox 40 beta 7, build ID: 20150723165742.

Ran into issue 1185889 on DevEdition.