1175393 - Confirmation Screen when terminating a call from contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Marcia Knous [:marcia]]

Attachment: 2015-06-16-22-27-50.png

[Blocking Requested - why for this release]:

Similar to Bug Bug 1163732, but not exactly the same STR. Seen on Z3 running:

Gaia-Rev        f36b1c0a4fad5d64c4c8e52ac2ac525632a8e673
Gecko-Rev       3c3d7b9c02a81114bb27142eb1a4fc177709217b
Build-ID        20150616235851
Version         41.0a1
Device-Name     aries
FW-Release      4.4.2
FW-Incremental  eng.worker.20150616.234403
FW-Date         Tue Jun 16 23:44:13 UTC 2015
Bootloader      s1

STR:
1. Open the contacts app and press the telephone icon to dial the phone.
2. On the receiving phone, terminate the call.
3. Receive the attached screenshot

the bug does not seem to happen if you terminate the call from the Z3, only from the receiving phone.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Likely another fallout of bug 1066347. QA wanted to check the build before April 10th 2015 at 04:16:20 Pacific Time, and the build after.

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This happens on builds from before the 10th.  Note that this issue only occurs if the recieving device does not forward to voicemail.  If the device answers or voicemail picks up this issue does NOT occur.  

Below is the earliest build we have available because of bug 1133074, from the 16th of May, and still reproduces this issue.  This is also NOT Aries specific and happens on 3.0 Flame.  Leaving qawanted and doing further branch checks now to determine if this is a regression or not.

Environmental Variables:
Device: Aries 3.0
BuildID: 20150516173908
Gaia: 4c0f36e9dfe017bf2a698d416a57c8156b43383d
Gecko: 2f6ea66057fe
Gonk: 3af1ede0d0956cfbf9c549df7cd9a6807a9efdf2
Version: 41.0a1 (3.0) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Environmental Variables:
Device: Flame 3.0
BuildID: 20150612010203
Gaia: 9f36b711af7597a6a32471c3305cf1e2d6947d39
Gecko: 0093691d3715
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue does NOT occur on 2.2 Flame KK.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150617002504
Gaia: 3414b07dc489976bf510fd8042c0af3b1192c160
Gecko: a2db74491088
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Johan's prediction from comment 2 about bug 1066347 seems to be correct.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150410033337
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: b99b34dc9bd4
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150410044437
Gaia: 6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: 5a1b56e833f0
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 749b6eb12c103f4119f1f85c72dbe7791684d8dc
Gecko: 5a1b56e833f0

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: 6e403dbb863fb9ec41bd22b6583e2eff5045d78b
Gecko: b99b34dc9bd4

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/749b6eb12c103f4119f1f85c72dbe7791684d8dc...6e403dbb863fb9ec41bd22b6583e2eff5045d78b

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Please also see bug 1173606 which has the same regression window.

Comment 6

[Marcia Knous [:marcia]]

ni on nhirata and drs to weigh in here.

Comment 7

[Doug Sherk (:drs) (inactive)]

Not a blocker, but let's get this fixed ASAP.

Bringing in Francisco and Zibi to take a look.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

The screen is here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/elements/confirm.html

But it doesn't have l10n-id's so they have to be provided from JS from a context that doesn't have the resources linked. It would be helpful to have a logcat from that session.

Comment 9

[Marcia Knous [:marcia]]

Attachment: Logcat while testing

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

(...)
W/Communications( 4598): Content JS WARN: L10nError: "numberIsBusyTitle" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 4598):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:286:261)
W/Communications( 4598): Content JS WARN: L10nError: "numberIsBusyMessage" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 4598):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:286:261)
W/Communications( 4598): Content JS WARN: L10nError: "emergencyDialogBtnOk" not found in en-US in app://communications.gaiamobile.org/contacts/index.html 
W/Communications( 4598):     at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:286:261)
(...)

The entities are defined in ./shared/locales/telephony/telephony.properties and never linked from ./apps/communications//contacts/index.html which loads confirm.html

Comment 11

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Like the other fallouts of bug 1066347, we should prevent this kind of regressions in 2.5

Comment 12

[Johan Lorenzo [:jlorenzo]]

Comms triage: Functional regression.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1175393 > mozilla-b2g:master

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8646893 [details] [review]
[gaia] arcturus:bug-1175393 > mozilla-b2g:master

r=me

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/f9f000b23c0f02aa326600a0fa7b1f3690696004

Comment 16

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The prompt message shows normally and no broken error message screen encountered.
See attachment: verified_FlameKK_v2.5.3gp or verified_FlameKK_v2.5.png.
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150813150207
Gaia Revision          acfaa3957e65d52a0af2185149628a520edcc7e2
Gaia Date              2015-08-13 12:34:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cdf53a4dee219aabec7462888875bac08b093edc
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150813.184539
Firmware Date          Thu Aug 13 18:45:52 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150814002719
Gaia Revision          39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gaia Date              2015-08-13 18:25:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150813.235024
Firmware Date          Thu Aug 13 23:50:32 UTC 2015
Bootloader             s1

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.png

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp